From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Cc: "Koosha Khajehmoogahi" <koosha@posteo.de>,
"Michael J Gruber" <git@drmicha.warpmail.net>,
"Jeff King" <peff@peff.net>, "Paul Tan" <pyokagan@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>,
"Jakub Narębski" <jnareb@gmail.com>
Subject: Re: What's cooking in git.git (Apr 2015, #04; Mon, 27)
Date: Thu, 30 Apr 2015 08:55:12 +0200 [thread overview]
Message-ID: <5541D1D0.8070407@alum.mit.edu> (raw)
In-Reply-To: <xmqqbni64kum.fsf@gitster.dls.corp.google.com>
On 04/30/2015 12:42 AM, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Here are the topics that have been cooking. Commits prefixed with
>> '-' are only in 'pu' (proposed updates) while commits prefixed with
>> '+' are in 'next'.
>> ...
>
> There are a handful of topics that are almost there but not
> finished. Could the topic owners and area submaintainers who are
> involved in them report their current status soonish, please, to
> help me decide to keep or discard them?
> [...]
>> * mh/numparse (2015-03-19) 14 commits
>> - diff_opt_parse(): use convert_i() when handling --abbrev=<num>
>> - diff_opt_parse(): use convert_i() when handling "-l<num>"
>> - opt_arg(): simplify pointer handling
>> - opt_arg(): report errors parsing option values
>> - opt_arg(): use convert_i() in implementation
>> - opt_arg(): val is always non-NULL
>> - builtin_diff(): detect errors when parsing --unified argument
>> - handle_revision_opt(): use convert_ui() when handling "--abbrev="
>> - strtoul_ui(), strtol_i(): remove functions
>> - handle_revision_opt(): use convert_i() when handling "-<digit>"
>> - handle_revision_opt(): use skip_prefix() in many places
>> - write_subdirectory(): use convert_ui() for parsing mode
>> - cacheinfo_callback(): use convert_ui() when handling "--cacheinfo"
>> - numparse: new module for parsing integral numbers
>>
>> Many codepaths use unchecked use of strtol() and friends (or even
>> worse, atoi()). Introduce a set of wrappers that try to be more
>> careful.
>>
>> Waiting for a reroll ($gmane/266209).
Yes, I've started rerolling this series a bit less ambitiously; i.e.,
introduce the numparse API but in the first iteration avoid changing the
behavior of the code that is doing the parsing. No ETA, I'm afraid.
Feel free to drop v1 from your repository unless you think it might be
useful as a reminder or object for discussion or something.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
next prev parent reply other threads:[~2015-04-30 6:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 20:01 What's cooking in git.git (Apr 2015, #04; Mon, 27) Junio C Hamano
2015-04-29 22:42 ` Junio C Hamano
2015-04-29 22:50 ` Koosha Khajehmoogahi
2015-04-30 1:38 ` Junio C Hamano
2015-04-30 0:18 ` Paul Tan
2015-04-30 1:37 ` Junio C Hamano
2015-04-30 1:02 ` Jeff King
2015-04-30 1:36 ` Junio C Hamano
2015-04-30 6:55 ` Michael Haggerty [this message]
2015-04-30 8:00 ` Michael J Gruber
2015-04-30 8:21 ` Michael Haggerty
2015-04-30 1:07 ` Duy Nguyen
2015-04-30 1:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5541D1D0.8070407@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=koosha@posteo.de \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=pyokagan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).