git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stefan Beller <sbeller@google.com>, Jeff King <peff@peff.net>,
	Eric Sunshine <sunshine@sunshineco.com>,
	git@vger.kernel.org
Subject: Re: [PATCH v2 0/8] Fix atomicity and avoid fd exhaustion in ref transactions
Date: Mon, 11 May 2015 08:52:57 +0200	[thread overview]
Message-ID: <555051C9.7040204@alum.mit.edu> (raw)
In-Reply-To: <xmqqr3qng2h4.fsf@gitster.dls.corp.google.com>

On 05/11/2015 06:30 AM, Junio C Hamano wrote:
> Michael Haggerty <mhagger@alum.mit.edu> writes:
> 
>> The following other branches, also from my GitHub repo, might be
>> useful:
>>
>> * 'write-refs-sooner-2.3' -- suggested merge of the change to 'maint'.
>>
>> * 'write-refs-sooner-master' -- suggested merge of the change to
>>   'master'.
>>
>> * 'write-refs-sooner-rebased-2.3' and
>>   'write-refs-sooner-rebased-master' -- rebases of 'write-refs-sooner'
>>   onto 'maint' and 'master' respectively, in case anybody is
>>   interested to see how the individual patches would look if
>>   implemented natively on these branches.
> 
> Thanks, that indeed is very helpful and instructive.
> 
> A mechanical merge of sooner-2.2 to maint trivially gave sooner-2.3,
> so I am happy with that one.
> 
> Even though I manually resolved it and the resulting tree pretty
> much matched with your suggested merge, I am hesitant to record the
> change of sooner-2.3 as a single large merge to master.  I am
> tempted to record this as somewhat a wicked merge, e.g.
> 
>  - apply posted patches on maint-2.2, which is your sooner-2.2;
> 
>  - branch sooner-2.3 from maint, merge sooner-2.2;
> 
>  - branch sooner-master from v2.4.0, apply the patches in your
>    sooner-rebased-master on top, and then merge sooner-2.3, possibly
>    with "-s ours"
> 
> And then sooner-master would record both "if built naturally on 2.4"
> progression, which would explain what was done much better than a
> huge merge of sooner-2.3 into 'master', and "what is to be done on
> older codebase".

This is exactly the kind of case that "rebase with history" [1] was
meant to address. But given that our tooling doesn't support such
complicated histories very well, your plan sounds reasonable.

Michael

[1]
http://softwareswirl.blogspot.de/2009/04/truce-in-merge-vs-rebase-war.html

-- 
Michael Haggerty
mhagger@alum.mit.edu

  reply	other threads:[~2015-05-11  6:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-10  2:45 [PATCH v2 0/8] Fix atomicity and avoid fd exhaustion in ref transactions Michael Haggerty
2015-05-10  2:45 ` [PATCH v2 1/8] update-ref: test handling large transactions properly Michael Haggerty
2015-05-10  2:45 ` [PATCH v2 2/8] t7004: rename ULIMIT test prerequisite to ULIMIT_STACK_SIZE Michael Haggerty
2015-05-11 17:23   ` Stefan Beller
2015-05-12 21:53     ` Junio C Hamano
2015-05-10  2:45 ` [PATCH v2 3/8] write_ref_to_lockfile(): new function, extracted from write_ref_sha1() Michael Haggerty
2015-05-10  2:45 ` [PATCH v2 4/8] commit_ref_update(): " Michael Haggerty
2015-05-10  2:45 ` [PATCH v2 5/8] rename_ref(): inline calls to write_ref_sha1() from this function Michael Haggerty
2015-05-10  2:45 ` [PATCH v2 6/8] ref_transaction_commit(): inline call to write_ref_sha1() Michael Haggerty
2015-05-10  2:45 ` [PATCH v2 7/8] ref_transaction_commit(): remove the local flags variable Michael Haggerty
2015-05-10  2:45 ` [PATCH v2 8/8] ref_transaction_commit(): fix atomicity and avoid fd exhaustion Michael Haggerty
2015-05-11  4:30 ` [PATCH v2 0/8] Fix atomicity and avoid fd exhaustion in ref transactions Junio C Hamano
2015-05-11  6:52   ` Michael Haggerty [this message]
2015-05-11 17:10     ` Stefan Beller
2015-05-12 13:26       ` Christian Couder
2015-05-11 17:32   ` Stefan Beller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555051C9.7040204@alum.mit.edu \
    --to=mhagger@alum.mit.edu \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=sbeller@google.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).