From: Johannes Sixt <j6t@kdbg.org>
To: dturner@twopensource.com, git@vger.kernel.org
Cc: David Turner <dturner@twitter.com>
Subject: Re: [PATCH v5 1/3] tree-walk: learn get_tree_entry_follow_symlinks
Date: Tue, 12 May 2015 19:29:01 +0200 [thread overview]
Message-ID: <5552385D.1050303@kdbg.org> (raw)
In-Reply-To: <1431384645-17276-2-git-send-email-dturner@twopensource.com>
Am 12.05.2015 um 00:50 schrieb dturner@twopensource.com:
> + } else if (S_ISLNK(*mode)) {
> + /* Follow a symlink */
> + size_t link_len, len;
> + char *contents, *contents_start;
> + struct dir_state *parent;
> + enum object_type type;
> +
> + if (follows_remaining-- == 0)
> + /* Too many symlinks followed */
> + goto done;
> +
> + contents = read_sha1_file(current_tree_sha1, &type,
> + &link_len);
In this line, I get:
tree-walk.c: In function 'get_tree_entry_follow_symlinks':
tree-walk.c:637: warning: passing argument 3 of 'read_sha1_file' from
incompatible pointer type
cache.h:885: note: expected 'long unsigned int *' but argument is of
type 'size_t *'
-- Hannes
next prev parent reply other threads:[~2015-05-12 17:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 22:50 [PATCH v5 0/3] cat-file --follow-symlinks dturner
2015-05-11 22:50 ` [PATCH v5 1/3] tree-walk: learn get_tree_entry_follow_symlinks dturner
2015-05-12 17:29 ` Johannes Sixt [this message]
2015-05-11 22:50 ` [PATCH v5 2/3] sha1_name: get_sha1_with_context learns to follow symlinks dturner
2015-05-11 22:50 ` [PATCH v5 3/3] cat-file: add --follow-symlinks to --batch dturner
2015-05-12 17:34 ` Johannes Sixt
2015-05-12 18:07 ` Junio C Hamano
2015-05-12 18:36 ` David Turner
2015-05-12 18:43 ` Junio C Hamano
2015-05-12 18:55 ` David Turner
2015-05-12 20:00 ` Junio C Hamano
2015-05-12 20:22 ` Junio C Hamano
2015-05-12 22:36 ` David Turner
2015-05-12 23:02 ` Junio C Hamano
2015-05-12 23:06 ` Junio C Hamano
2015-05-12 20:07 ` Junio C Hamano
2015-05-12 21:37 ` David Turner
2015-05-12 21:42 ` Junio C Hamano
2015-05-12 21:53 ` David Turner
2015-05-14 20:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5552385D.1050303@kdbg.org \
--to=j6t@kdbg.org \
--cc=dturner@twitter.com \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).