* [PATCH] help.c: mark a file-local function static
@ 2015-05-19 19:15 Ramsay Jones
2015-05-19 19:17 ` Sébastien Guimmara
0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2015-05-19 19:15 UTC (permalink / raw)
To: sebastien.guimmara; +Cc: Junio C Hamano, GIT Mailing-list
Commit 4f671d74 ("help: respect new common command grouping",
18-05-2015) adds the 'cmd_group_cmp' funtion as an external
symbol.
Noticed by sparse. ("'cmd_group_cmp' was not declared. Should it
be static?")
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Sebastien,
If you need to re-roll the patches in your 'sg/help-group' branch,
could you please squash this into the relevant patch (commit 4f671d74).
Thanks!
ATB,
Ramsay Jones
help.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/help.c b/help.c
index 71027b7..7881ab7 100644
--- a/help.c
+++ b/help.c
@@ -218,7 +218,7 @@ void list_commands(unsigned int colopts,
}
}
-int cmd_group_cmp(const void *elem1, const void *elem2)
+static int cmd_group_cmp(const void *elem1, const void *elem2)
{
const struct cmdname_help *e1 = elem1;
const struct cmdname_help *e2 = elem2;
--
2.4.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] help.c: mark a file-local function static
2015-05-19 19:15 [PATCH] help.c: mark a file-local function static Ramsay Jones
@ 2015-05-19 19:17 ` Sébastien Guimmara
0 siblings, 0 replies; 2+ messages in thread
From: Sébastien Guimmara @ 2015-05-19 19:17 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Git Users
Hi Ramsay,
thanks for pointing that out, will squash it.
Sébastien
On 05/19/2015 09:15 PM, Ramsay Jones wrote:
>
> Commit 4f671d74 ("help: respect new common command grouping",
> 18-05-2015) adds the 'cmd_group_cmp' funtion as an external
> symbol.
>
> Noticed by sparse. ("'cmd_group_cmp' was not declared. Should it
> be static?")
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Hi Sebastien,
>
> If you need to re-roll the patches in your 'sg/help-group' branch,
> could you please squash this into the relevant patch (commit 4f671d74).
>
> Thanks!
>
> ATB,
> Ramsay Jones
>
> help.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/help.c b/help.c
> index 71027b7..7881ab7 100644
> --- a/help.c
> +++ b/help.c
> @@ -218,7 +218,7 @@ void list_commands(unsigned int colopts,
> }
> }
>
> -int cmd_group_cmp(const void *elem1, const void *elem2)
> +static int cmd_group_cmp(const void *elem1, const void *elem2)
> {
> const struct cmdname_help *e1 = elem1;
> const struct cmdname_help *e2 = elem2;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-19 19:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-19 19:15 [PATCH] help.c: mark a file-local function static Ramsay Jones
2015-05-19 19:17 ` Sébastien Guimmara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).