From: Bastien Traverse <bt@esrevart.net>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [RESOLVED NOTABUG] "git commit --date" format parsing
Date: Sun, 24 May 2015 01:24:03 +0200 [thread overview]
Message-ID: <55610C13.4090802@esrevart.net> (raw)
In-Reply-To: <20150522220610.GA21848@peff.net>
Le 23/05/2015 00:06, Jeff King a écrit :
> OK, this is weird. When I tried to reproduce, I couldn't. But I had
> typed in the date string myself while reading your email in another
> window. And though I was sure that I had typed it correctly, just to be
> double-plus-sure I copied and pasted your string. And it failed!
>
> The date string in your email looks like this (using cut and paste):
>
> $ echo 2015-05-21T16∶31+02:00 | xxd
> 00000000: 3230 3135 2d30 352d 3231 5431 36e2 88b6 2015-05-21T16...
> 00000010: 3331 2b30 323a 3030 0a 31+02:00.
>
> Your "colon" is actually UTF-8 for code point . So git's
> date parser does not recognize it, and punts to approxidate(), which
> does all manner of crazy guessing trying to figure out what you meant.
Okay, this is crazy. Now I can't reproduce it myself either: I just
repeated the procedure and date parsing works as expected. The only
difference with my last email is that I upgraded and rebooted my system
(there was a kernel update for 4.0.4 on Arch... Among other things). I
guess that would have reset my keyboard layout, but I swear I tested it
multiple times over a few days before posting here.
Anyway, thanks for your insight I would have never figured this myself.
I'll be wary of silent unicode character substitution :)
Just for the record:
$ localectl
System Locale: LANG=fr_FR.UTF8
VC Keymap: fr
X11 Layout: fr
X11 Variant: oss
And I am using the default monospace font in gnome-terminal and gedit.
Pretty basic stuff, really.
Thanks again,
Bastien
prev parent reply other threads:[~2015-05-23 23:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 13:18 [BUG] "git commit --date" format parsing Bastien Traverse
2015-05-22 22:06 ` Jeff King
2015-05-23 23:24 ` Bastien Traverse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55610C13.4090802@esrevart.net \
--to=bt@esrevart.net \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).