From: Karthik Nayak <karthik.188@gmail.com>
To: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Cc: git@vger.kernel.org, christian.couder@gmail.com
Subject: Re: [PATCH/WIP v3 2/4] for-each-ref: introduce new structures for better organisation
Date: Fri, 29 May 2015 02:13:08 +0530 [thread overview]
Message-ID: <55677DDC.2070601@gmail.com> (raw)
In-Reply-To: <vpq8uc8l9k0.fsf@anie.imag.fr>
On 05/29/2015 02:11 AM, Matthieu Moy wrote:
> The point of separating them is that the rename implies a relatively
> long patch (you have 17 occurences of 'refinfo' in the deletion part of
> your patch), but it is straightforward to review (apply, run "git diff
> --color-words" and press space a few times). But it is no longer so
> simple once you mix it with anything else.
>
Makes sense, thanks for putting it out.
--
Regards,
Karthik
next prev parent reply other threads:[~2015-05-28 20:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 17:38 [PATCH/WIP v3 1/4] for-each-ref: re-structure code for moving to 'ref-filter' Karthik Nayak
2015-05-28 17:43 ` [PATCH/WIP v3 1/4] for-each-ref: extract helper functions out of grab_single_ref() Karthik Nayak
2015-05-28 20:13 ` Matthieu Moy
2015-05-28 20:33 ` Karthik Nayak
2015-05-28 17:43 ` [PATCH/WIP v3 2/4] for-each-ref: introduce new structures for better organisation Karthik Nayak
2015-05-28 20:26 ` Matthieu Moy
2015-05-28 20:37 ` Karthik Nayak
2015-05-28 20:41 ` Matthieu Moy
2015-05-28 20:43 ` Karthik Nayak [this message]
2015-05-28 21:18 ` Junio C Hamano
2015-05-28 21:28 ` Junio C Hamano
2015-05-28 17:43 ` [PATCH/WIP v3 3/4] for-each-ref: rename some functions and make them public Karthik Nayak
2015-05-28 17:43 ` [PATCH/WIP v3 4/4] ref-filter: move code from 'for-each-ref' Karthik Nayak
2015-05-28 20:35 ` Matthieu Moy
2015-05-28 20:46 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55677DDC.2070601@gmail.com \
--to=karthik.188@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=matthieu.moy@grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).