From: "Alf Clement" <alf.clement@gmail.com>
To: "Alex Riesen" <raa.lkml@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <junkio@cox.net>
Subject: Re: [PATCH] Add test-tr: poor-man tr
Date: Thu, 12 Jun 2008 08:32:26 +0200 [thread overview]
Message-ID: <556d90580806112332s25f76caajaaafa8e16e895922@mail.gmail.com> (raw)
In-Reply-To: <20080611182501.GA3344@steel.home>
Hi Alex,
> +static unsigned char *unquote(const char *s, unsigned *len)
> +{
> + unsigned char *result = malloc(strlen(s)), *r = result;
are you sure that the buffer is big enough?? Nomally you do a
malloc(strlen(s)+1).
CU,
Alf
next prev parent reply other threads:[~2008-06-12 6:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 18:25 [PATCH] Add test-tr: poor-man tr Alex Riesen, Alex Riesen
2008-06-11 18:26 ` [PATCH] Use test-tr in the tests Alex Riesen
2008-06-11 21:34 ` [PATCH] Add test-tr: poor-man tr Alex Riesen
2008-06-11 22:54 ` Jeff King
2008-06-12 6:01 ` Alex Riesen
2008-06-12 6:23 ` Jeff King
2008-06-12 6:28 ` Jeff King
2008-06-12 20:32 ` Alex Riesen
2008-06-13 6:02 ` Jeff King
2008-06-13 17:26 ` Alex Riesen
2008-06-13 18:00 ` Jeff King
2008-06-12 6:32 ` Alf Clement [this message]
2008-06-12 7:25 ` Johannes Schindelin
2008-06-12 20:20 ` Alex Riesen, Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556d90580806112332s25f76caajaaafa8e16e895922@mail.gmail.com \
--to=alf.clement@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).