From: Michael Haggerty <mhagger@alum.mit.edu>
To: "brian m. carlson" <sandals@crustytoothpaste.net>,
Jeff King <peff@peff.net>,
git@vger.kernel.org, Stefan Beller <sbeller@google.com>,
Duy Nguyen <pclouds@gmail.com>
Subject: Re: Pack files, standards compliance, and efficiency
Date: Fri, 05 Jun 2015 22:03:27 +0200 [thread overview]
Message-ID: <5572008F.6030203@alum.mit.edu> (raw)
In-Reply-To: <20150605194200.GB356121@vauxhall.crustytoothpaste.net>
On 06/05/2015 09:42 PM, brian m. carlson wrote:
> On Fri, Jun 05, 2015 at 05:22:08PM +0200, Michael Haggerty wrote:
>> I don't know that there would necessarily be problems, but I
>> would worry about code involving structure assignment. For
>> example, suppose the following snippet:
>>
>> void f(struct object_id *oid) { struct object_id oid_copy =
>> *oid; /* ... */ }
>>
>> The compiler is allowed to implement the copy using instructions
>> that rely on proper alignment. Such code would fail if oid is not
>> properly aligned.
>
> We use oidcpy which doesn't use object assignment. I brought that
> up previously, and Junio was opposed to doing *dest = *src. So I
> don't think this ends up being an issue.
Sorry for overlooking (or forgetting :-( ) that discussion. Indeed,
that would allay my worry.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
prev parent reply other threads:[~2015-06-05 20:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 1:41 Pack files, standards compliance, and efficiency brian m. carlson
2015-06-05 9:45 ` Jeff King
2015-06-05 10:14 ` Duy Nguyen
2015-06-05 10:36 ` Jeff King
2015-06-05 13:24 ` Duy Nguyen
2015-06-05 19:59 ` brian m. carlson
2015-06-05 16:43 ` Junio C Hamano
2015-06-05 15:22 ` Michael Haggerty
2015-06-05 19:42 ` brian m. carlson
2015-06-05 20:03 ` Michael Haggerty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5572008F.6030203@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).