From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karthik Nayak Subject: Re: [WIP/PATCH v5 05/10] for-each-ref: introduce 'ref_array_clear()' Date: Mon, 08 Jun 2015 20:48:50 +0530 Message-ID: <5575B25A.6020608@gmail.com> References: <55729B78.1070207@gmail.com> <1433574581-23980-1-git-send-email-karthik.188@gmail.com> <1433574581-23980-5-git-send-email-karthik.188@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: git@vger.kernel.org, christian.couder@gmail.com To: Matthieu Moy X-From: git-owner@vger.kernel.org Mon Jun 08 17:19:00 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z1ypH-0006L6-2z for gcvg-git-2@plane.gmane.org; Mon, 08 Jun 2015 17:18:59 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752526AbbFHPSy (ORCPT ); Mon, 8 Jun 2015 11:18:54 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:36667 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752808AbbFHPSy (ORCPT ); Mon, 8 Jun 2015 11:18:54 -0400 Received: by pdjm12 with SMTP id m12so106830168pdj.3 for ; Mon, 08 Jun 2015 08:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=sCJCMGWBc4XxvTCSrG6sGUA5WI4A19CyjOqCEY8vXKU=; b=hjg4jjmmYAHQLEcKpx5+MAM256tOuVsj9JsMvnZhgfLlanZbCd623uCj1Lmd88xKyh x/oftDeeoIvPGv/EZakwgMqEqc2MubcRDypoDKC6uA1wCs+8JPxDtuxHAOC/HwPK/JfQ 4HSY5o86MXDViaknAJbruAxGdhsPUqBz9tE9xO8KvgH4ZrjEwClRozCu7tmsQS7kvF8u KCX7yLhpHQLeaaLcFXz4JctObQiEtOTO2E1D7DTETZnuxFmdM/rScFNKU0nh8FwKnGSs qntroKwqEDNqcftgIrovaozWmHava9A4iCvyDNVJzAPHx1Gi0/izqP+H18O7ly0vBcaE X6qw== X-Received: by 10.66.148.34 with SMTP id tp2mr30349392pab.65.1433776733824; Mon, 08 Jun 2015 08:18:53 -0700 (PDT) Received: from [192.168.0.100] ([106.51.130.23]) by mx.google.com with ESMTPSA id ck4sm2914250pbc.67.2015.06.08.08.18.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jun 2015 08:18:53 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On 06/08/2015 08:23 PM, Matthieu Moy wrote: > Karthik Nayak writes: > > > +/* Free all memory allocated for ref_array */ > > +void ref_array_clear(struct ref_array *array) > > Is this a private function? If so, then add static. If not, you probably > want to export it in a .h file. > It is in ref-filter.h. -- Regards, Karthik