From: Karthik Nayak <karthik.188@gmail.com>
To: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Cc: git@vger.kernel.org, christian.couder@gmail.com
Subject: Re: [PATCH v6 09/11] ref-filter: move code from 'for-each-ref'
Date: Mon, 08 Jun 2015 22:43:25 +0530 [thread overview]
Message-ID: <5575CD35.4030705@gmail.com> (raw)
In-Reply-To: <vpq4mmiw2jy.fsf@anie.imag.fr>
On 06/08/2015 10:38 PM, Matthieu Moy wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
> > --- a/builtin/for-each-ref.c
> > +++ b/builtin/for-each-ref.c
> > @@ -1129,7 +56,7 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix)
> >
> > memset(&ref_cbdata, 0, sizeof(ref_cbdata));
> > ref_cbdata.filter.name_patterns = argv;
> > - for_each_rawref(ref_filter_handler, &ref_cbdata);
> > + filter_refs(for_each_rawref, &ref_cbdata);
>
> This seems unrelated from the rest of the patch. And you haven't
> introduced filter_refs yet!
>
That definitely is, this happened after fixing merges I suppose.
Ignore it for now, I'll fix it.
--
Regards,
Karthik
next prev parent reply other threads:[~2015-06-08 17:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-06 13:43 [PATCH v6 0/11] create ref-filter from for-each-ref Karthik Nayak
2015-06-06 13:48 ` [PATCH v6 01/11] for-each-ref: extract helper functions out of grab_single_ref() Karthik Nayak
2015-06-06 13:48 ` [PATCH v6 02/11] for-each-ref: clean up code Karthik Nayak
2015-06-06 13:48 ` [PATCH v6 03/11] for-each-ref: rename 'refinfo' to 'ref_array_item' Karthik Nayak
2015-06-06 13:48 ` [PATCH v6 04/11] for-each-ref: introduce new structures for better organisation Karthik Nayak
2015-06-06 13:48 ` [PATCH v6 05/11] for-each-ref: introduce 'ref_array_clear()' Karthik Nayak
2015-06-06 13:48 ` [PATCH v6 06/11] for-each-ref: rename some functions and make them public Karthik Nayak
2015-06-06 13:48 ` [PATCH v6 07/11] for-each-ref: rename variables called sort to sorting Karthik Nayak
2015-06-06 13:48 ` [PATCH v6 08/11] ref-filter: add 'ref-filter.h' Karthik Nayak
2015-06-06 13:48 ` [PATCH v6 09/11] ref-filter: move code from 'for-each-ref' Karthik Nayak
2015-06-07 10:34 ` Karthik Nayak
2015-06-08 17:08 ` Matthieu Moy
2015-06-08 17:13 ` Karthik Nayak [this message]
2015-06-08 18:08 ` Junio C Hamano
2015-06-06 13:48 ` [PATCH v6 10/11] for-each-ref: introduce filter_refs() Karthik Nayak
2015-06-07 10:36 ` Karthik Nayak
2015-06-08 18:15 ` Junio C Hamano
2015-06-08 18:37 ` Karthik Nayak
2015-06-06 13:48 ` [PATCH v6 11/11] ref-filter: make 'ref_array_item' use a FLEX_ARRAY for refname Karthik Nayak
2015-06-08 18:02 ` [PATCH v6 01/11] for-each-ref: extract helper functions out of grab_single_ref() Junio C Hamano
2015-06-08 18:33 ` Karthik Nayak
2015-06-07 12:03 ` [PATCH v6 0/11] create ref-filter from for-each-ref Karthik Nayak
2015-06-08 17:15 ` Matthieu Moy
2015-06-08 17:18 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5575CD35.4030705@gmail.com \
--to=karthik.188@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=matthieu.moy@grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).