From: "Jakub Narębski" <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, josh@joshtriplett.org
Cc: Tuncer Ayaz <tuncer.ayaz@gmail.com>,
git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>
Subject: Re: co-authoring commits
Date: Thu, 18 Jun 2015 23:25:44 +0200 [thread overview]
Message-ID: <55833758.6010000@gmail.com> (raw)
In-Reply-To: <xmqq381q551o.fsf@gitster.dls.corp.google.com>
Junio C Hamano wrote:
> josh@joshtriplett.org writes:
>
>> Author and committer are used by many git tools; if they weren't part of
>> the object header, they'd need to be part of some pseudo-header with a
>> standardized format that git can parse.
>
> Yes, the same goes to the address on Signed-off-by: footers. There
> recently was a series to enhance the footer list handling (Christian
> Cc'ed) for the generation and maintenance side, and I do think it is
> reasonable to further add enhanced support for footers.
>
> That does not argue for having a new "coauthor" as a new commit
> object header at all, though.
The threshold for modifying commit object is high. This is an
ABI-level change, something to do if there is no other solution.
Author and committer include datetime in the contents of the
field, which is used by Git for heuristics limiting walk. Coauthor
would have the same date as author, isn't it? If, after long
and involved discussion, we didn't add 'generation' field (for
easier cutting history walking), what chance adding 'coauthor'
has.
OTOH it would be nice to have support for .mailmap, and for
grepping... but the former could conceivably be added to the trailer
tool, the latter can be done with appropriate regexp in
"git log --grep=...".
I wonder what would break if one used 'Name <e@mai.l>, Name <em@i.l>'
as the author...
--
Jakub Narębski
next prev parent reply other threads:[~2015-06-18 21:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 19:52 co-authoring commits Tuncer Ayaz
2015-06-17 19:58 ` Junio C Hamano
2015-06-17 20:26 ` Tuncer Ayaz
2015-06-17 20:57 ` Junio C Hamano
2015-06-17 21:17 ` josh
2015-06-17 20:59 ` josh
2015-06-17 21:51 ` Junio C Hamano
2015-06-17 22:07 ` Tuncer Ayaz
2015-06-17 22:28 ` josh
2015-06-17 22:44 ` Junio C Hamano
2015-06-18 21:25 ` Jakub Narębski [this message]
2015-06-19 4:25 ` Jeff King
2015-06-19 18:02 ` Jakub Narębski
2015-06-17 22:52 ` Theodore Ts'o
2015-06-17 23:06 ` josh
2015-06-18 10:54 ` Jason Pyeron
2015-06-18 21:25 ` Tuncer Ayaz
2015-06-19 18:18 ` Jakub Narębski
2015-06-19 21:11 ` Tuncer Ayaz
2015-06-19 21:25 ` Jakub Narębski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55833758.6010000@gmail.com \
--to=jnareb@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=josh@joshtriplett.org \
--cc=tuncer.ayaz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).