git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Haggerty <mhagger@alum.mit.edu>
To: Eric Sunshine <sunshine@sunshineco.com>, git@vger.kernel.org
Cc: Duy Nguyen <pclouds@gmail.com>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 0/5] mh: worktree-related doc fixes
Date: Mon, 20 Jul 2015 08:31:57 -0700	[thread overview]
Message-ID: <55AD146D.3080509@alum.mit.edu> (raw)
In-Reply-To: <1437370162-8031-1-git-send-email-sunshine@sunshineco.com>

On 07/19/2015 10:29 PM, Eric Sunshine wrote:
> This re-roll of Michael Haggerty's worktree-related documentation
> tweaks[1] takes my review comments into account and adds one new patch.

Eric,

Thanks for separating the wheat from the chaff. I'm still traveling,
which I'll claim as an excuse for my poor responsiveness.

All of your changes look good.

I was wondering one thing: is there a value like "never" or "false" to
which "gc.worktreepruneexpire" can be set to turn off pruning entirely?
If so, it might be nice to mention it in the config manpage. Similarly
for the other expiration grace time settings.

But it's definitely not a blocker.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu

  parent reply	other threads:[~2015-07-20 15:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20  5:29 [PATCH v2 0/5] mh: worktree-related doc fixes Eric Sunshine
2015-07-20  5:29 ` [PATCH v2 1/5] Documentation/git-worktree: consistently use term "linked working tree" Eric Sunshine
2015-07-20  5:29 ` [PATCH v2 2/5] Documentation/git-worktree: fix incorrect reference to file "locked" Eric Sunshine
2015-07-20  5:29 ` [PATCH v2 3/5] Documentation/config: fix stale "git prune --worktree" reference Eric Sunshine
2015-07-20  5:29 ` [PATCH v2 4/5] Documentation/git-worktree: wordsmith worktree-related manpages Eric Sunshine
2015-07-20  5:29 ` [PATCH v2 5/5] config: rename "gc.pruneWorktreesExpire" to "gc.worktreePruneExpire" Eric Sunshine
2015-07-20 15:31 ` Michael Haggerty [this message]
2015-07-24  0:10   ` [PATCH v2 0/5] mh: worktree-related doc fixes Eric Sunshine
2015-07-24  0:51     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55AD146D.3080509@alum.mit.edu \
    --to=mhagger@alum.mit.edu \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).