From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Sixt Subject: Re: [msysGit] Re: [PATCH bc/connect-plink] t5601-clone: remove broken and pointless check for plink.exe Date: Thu, 13 Aug 2015 20:07:13 +0200 Message-ID: <55CCDCD1.4080109@kdbg.org> References: <55CA6066.5070500@kdbg.org> <866a41f50ef9b4807da72576a4bca717@www.dscho.org> <55CB9110.4060005@kdbg.org> <43f88e9611755e20715bf9f38795f276@www.dscho.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: kusmabite@gmail.com, Git Mailing List , msysGit To: Johannes Schindelin X-From: git-owner@vger.kernel.org Thu Aug 13 20:07:26 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZPwuT-0004gM-4v for gcvg-git-2@plane.gmane.org; Thu, 13 Aug 2015 20:07:25 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753077AbbHMSHU (ORCPT ); Thu, 13 Aug 2015 14:07:20 -0400 Received: from bsmtp8.bon.at ([213.33.87.20]:57027 "EHLO bsmtp8.bon.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751559AbbHMSHT (ORCPT ); Thu, 13 Aug 2015 14:07:19 -0400 Received: from dx.site (unknown [93.83.142.38]) by bsmtp8.bon.at (Postfix) with ESMTPSA id 3msbTJ0CRWz5tlB; Thu, 13 Aug 2015 20:07:15 +0200 (CEST) Received: from [IPv6:::1] (localhost [IPv6:::1]) by dx.site (Postfix) with ESMTP id B0A3F52E1; Thu, 13 Aug 2015 20:07:13 +0200 (CEST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 In-Reply-To: <43f88e9611755e20715bf9f38795f276@www.dscho.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Am 13.08.2015 um 09:30 schrieb Johannes Schindelin: > Hi Johannes, > > On 2015-08-12 20:31, Johannes Sixt wrote: >> Am 12.08.2015 um 13:58 schrieb Erik Faye-Lund: >>> On Wed, Aug 12, 2015 at 1:07 PM, Johannes Schindelin >>> wrote: >>>> FWIW Git for Windows has this patch (that I wanted to contribute >>>> in due time, what with being busy with all those tickets) to solve the >>>> problem mentioned in your patch in a different way: >>>> >>>> https://github.com/git-for-windows/git/commit/2fff4b54a0d4e5c5e2e4638c9b0739d3c1ff1e45 >>> >>> Yuck. On Windows, it's the extension of a file that dictates what kind >>> of file it is (and if it's executable or not), not the contents. If we >>> get a shell script written with the ".exe"-prefix, it's considered as >>> an invalid executable by the system. We should consider it the same >>> way, otherwise we're on the path to user-experience schizophrenia. >>> >>> I'm not sure I consider this commit a step in the right direction. >> >> I, too, think that it is a wrong decision to pessimize git for the >> sake of a single test case. > > Oh, you make it sound as if you believe that I had indeed weakened > Git *just* for a single test case. Whatever. Since I do not have the time to provide hard numbers that prove my claim that your patch removes an optimization (and, furthermore, I do not want to reply to your arguments that I consider mostly philosophical rather than pragmatic), I bow out. Until this solution or that one is in upstream, I can help myself. Junio, please drop my patch. I do not have the nerves to support it. -- Hannes