From: "Torsten Bögershausen" <tboegi@web.de>
To: Luke Diamand <luke@diamand.org>,
larsxschneider@gmail.com, git@vger.kernel.org
Cc: pw@padd.com, torarvid@gmail.com, ksaitoh560@gmail.com, gitster@pobox.com
Subject: Re: [PATCH v5] git-p4: Obey core.ignorecase when using P4 client specs.
Date: Tue, 25 Aug 2015 10:33:33 +0200 [thread overview]
Message-ID: <55DC285D.9030500@web.de> (raw)
In-Reply-To: <55DC111A.6090501@diamand.org>
On 08/25/2015 08:54 AM, Luke Diamand wrote:
> On 24/08/15 22:30, larsxschneider@gmail.com wrote:
>> From: Lars Schneider <larsxschneider@gmail.com>
>>
>> Thanks to Luke Diamand I realized the core problem and propose here a
>> substiantially simpler fix to my PATCH v4.
>>
>> The test cases remain and prove the problem. In particular
>> "8 - Clone path (ignorecase)" and
>> "Add a new file and clone path with new file (ignorecase)" fail with the
>> current implementation on OS X and Linux.
>
> That's a lot simpler, thanks!
>
> Could we give this its own command line option and git config variable?
>
> Core.ignorecase gets set if the client is on a filing system that
> ignores case. This is slightly different - it squashes case in depot
> files for people with depots that have incorrectly jumbled-up case.
>
> Conflating the two seems like it would cause confusion at some point -
> for example, I have no idea how the rest of git behaves if
> core.ignorecase is set to True on a case-preserving file system.
>
That doesn't work as expected and is not allowed (or say strictly
forbidden, or strongly recommended not to do)
Remembering older discussions about importers from foreign VCS:
This should work best for most people:
Look at the command line option, if no one is given,
look at core.ignorecase.
So the command line option overrides core.ignorecase,
and the user can either run
--ignore-path-case
or
--no-ignore-path-case
PS:
Need to drop Eric from the list: the MX/A from from web.de problem still
exists
next prev parent reply other threads:[~2015-08-25 8:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 21:30 [PATCH v5] git-p4: Obey core.ignorecase when using P4 client specs larsxschneider
2015-08-24 21:30 ` larsxschneider
2015-08-25 6:54 ` Luke Diamand
2015-08-25 8:17 ` Lars Schneider
2015-08-25 8:33 ` Torsten Bögershausen [this message]
2015-08-25 10:30 ` Lars Schneider
2015-08-25 11:57 ` Luke Diamand
2015-08-25 13:14 ` Lars Schneider
2015-08-25 18:24 ` Luke Diamand
2015-08-26 10:18 ` Luke Diamand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DC285D.9030500@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ksaitoh560@gmail.com \
--cc=larsxschneider@gmail.com \
--cc=luke@diamand.org \
--cc=pw@padd.com \
--cc=torarvid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).