git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: Karthik Nayak <karthik.188@gmail.com>, git@vger.kernel.org
Cc: christian.couder@gmail.com, Matthieu.Moy@grenoble-inp.fr,
	gitster@pobox.com
Subject: Re: [PATCH v14 03/13] utf8: add function to align a string into given strbuf
Date: Sat, 29 Aug 2015 19:10:16 +0200	[thread overview]
Message-ID: <55E1E778.4030400@web.de> (raw)
In-Reply-To: <1440857537-13968-4-git-send-email-Karthik.188@gmail.com>

On 29.08.15 16:12, Karthik Nayak wrote:
> diff --git a/utf8.h b/utf8.h
> index 5a9e94b..7930b44 100644
> --- a/utf8.h
> +++ b/utf8.h
> @@ -55,4 +55,19 @@ int mbs_chrlen(const char **text, size_t *remainder_p, const char *encoding);
>   */
>  int is_hfs_dotgit(const char *path);
>  
> +typedef enum {
> +	ALIGN_LEFT,
> +	ALIGN_MIDDLE,
> +	ALIGN_RIGHT
> +} align_type;
should this be called strbuf_align_type ?

And is there a reason why the is in utf.c and not in stbuf.c ?

(I know that there is a lot of strbuf in utf8.c, but I hadn't managed to send a patch
to move everything into strbuf.c and make utf8.c un-aware of all strbub-business)

  reply	other threads:[~2015-08-29 17:10 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-29 14:12 [PATCH v14 00/13] Port tag.c to use ref-filter.c Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 01/13] ref-filter: move `struct atom_value` to ref-filter.c Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 02/13] ref-filter: introduce ref_formatting_state and ref_formatting_stack Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 03/13] utf8: add function to align a string into given strbuf Karthik Nayak
2015-08-29 17:10   ` Torsten Bögershausen [this message]
2015-08-29 17:33     ` Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 04/13] ref-filter: implement an `align` atom Karthik Nayak
2015-08-30  3:27   ` Eric Sunshine
2015-08-30 13:38     ` Karthik Nayak
2015-08-30 22:10       ` Eric Sunshine
2015-08-31  9:55         ` Karthik Nayak
2015-08-31 17:16           ` Eric Sunshine
2015-08-31 17:28             ` Matthieu Moy
2015-08-31 18:02               ` Eric Sunshine
2015-09-01 13:05                 ` Karthik Nayak
2015-09-01 13:11                   ` Matthieu Moy
2015-09-01 15:13                     ` Karthik Nayak
2015-08-30 14:57     ` Karthik Nayak
2015-08-30 21:59       ` Eric Sunshine
2015-08-31 10:06         ` Karthik Nayak
2015-08-30 17:27     ` Junio C Hamano
2015-08-30 22:56       ` Eric Sunshine
2015-08-31 10:14         ` Karthik Nayak
2015-08-31 10:28           ` Karthik Nayak
2015-08-31  8:30   ` Matthieu Moy
2015-08-31 10:59     ` Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 05/13] ref-filter: add option to filter out tags, branches and remotes Karthik Nayak
2015-08-30  3:30   ` Eric Sunshine
2015-08-30  6:51     ` Karthik Nayak
2015-08-30  7:16       ` Eric Sunshine
2015-08-29 14:12 ` [PATCH v14 06/13] ref-filter: introduce format_ref_array_item() Karthik Nayak
2015-08-30  3:42   ` Eric Sunshine
2015-08-30  6:39     ` Karthik Nayak
2015-08-30  6:49     ` Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 07/13] ref-filter: add support for %(contents:lines=X) Karthik Nayak
2015-08-30  7:53   ` Eric Sunshine
2015-08-30 17:02     ` Karthik Nayak
2015-08-30 17:09       ` Eric Sunshine
2015-08-30 17:17         ` Karthik Nayak
2015-08-30 22:13   ` Eric Sunshine
2015-08-31  4:43     ` Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 08/13] ref-filter: add support to sort by version Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 09/13] ref-filter: add option to match literal pattern Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 10/13] tag.c: use 'ref-filter' data structures Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 11/13] tag.c: use 'ref-filter' APIs Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 12/13] tag.c: implement '--format' option Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 13/13] tag.c: implement '--merged' and '--no-merged' options Karthik Nayak
2015-08-31  6:50 ` [PATCH v14 00/13] Port tag.c to use ref-filter.c Matthieu Moy
2015-08-31 11:09   ` Karthik Nayak
2015-08-31  7:31 ` Matthieu Moy
2015-08-31 11:36   ` Karthik Nayak
2015-09-01 17:37     ` Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E1E778.4030400@web.de \
    --to=tboegi@web.de \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=karthik.188@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).