git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael J Gruber <git@drmicha.warpmail.net>
To: Jacob Keller <jacob.keller@gmail.com>,
	"Rustad, Mark D" <mark.d.rustad@intel.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: git grep broken in Fedora 21 update?
Date: Fri, 4 Sep 2015 15:34:20 +0200	[thread overview]
Message-ID: <55E99DDC.2000900@drmicha.warpmail.net> (raw)
In-Reply-To: <CA+P7+xqzEHD9kR6suGBb1oXfPx0gehk7KYoUJFip_WcPWxTrPw@mail.gmail.com>

Jacob Keller venit, vidit, dixit 04.09.2015 06:55:
> On Thu, Sep 3, 2015 at 5:04 PM, Rustad, Mark D <mark.d.rustad@intel.com> wrote:
>> I just found a case where grep and git grep yield different results. Inside the ixgbe directory of the Linux kernel I did:
>>
>> $ grep enter_lplu *.[ch]
>>
>> And got the following:
>>
>> ixgbe_main.c:   if (adapter->hw.phy.ops.enter_lplu) {
>> ixgbe_main.c:           adapter->hw.phy.ops.enter_lplu(&adapter->hw);
>> ixgbe_type.h:   s32 (*enter_lplu)(struct ixgbe_hw *);
>> ixgbe_x550.c:/** ixgbe_enter_lplu_x550em - Transition to low power states
>> ixgbe_x550.c:static s32 ixgbe_enter_lplu_t_x550em(struct ixgbe_hw *hw)
>> ixgbe_x550.c:                   phy->ops.enter_lplu = ixgbe_enter_lplu_t_x550em;
>>
>> But when I did:
>>
>> $ git grep enter_lplu
>>
>> I got:
>>
>> ixgbe_main.c:   if (adapter->hw.phy.ops.enter_lplu) {
>> ixgbe_main.c:           adapter->hw.phy.ops.enter_lplu(&adapter->hw);
>> ixgbe_type.h:   s32 (*enter_lplu)(struct ixgbe_hw *);
>> ixgbe_x550.c:/** ixgbe_enter_lplu_x550em - Transition to low power states
>> ixgbe_x550.c:static s32 ixgbe_enter_lplu_t_x550em(struct ixgbe_hw *hw)
>>
>> You can see that git grep missed the line in ixgbe_x550.c that had two hits on the string.
>>
>> This was with git 2.1.0 in Fedora 21. I use git grep a lot and never noticed a problem before. I just updated my Fedora 21 system yesterday, so I have to figure that has something to do with it. I checked and git didn't get updated, so I figure it must be a library that is really broken.
>>
>> I see in my update log that pcre was updated to:
>>
>> pcre.x86_64 0:8.35-12.fc21
>> pcre-devel.x86_64 0:8.35-12.fc21
>>
>> Yet the grep command is unaffected.
>>
>> --
>> Mark Rustad, Networking Division, Intel Corporation
>>
> 
> I don't know if command line grep uses pcre?
> 
> Does git-grep by default ignore changes not yet committed? That was my
> first thought but I am not very familiar with the tool.
> 
> Regards,
> Jake
> 

Can you downgrade pcre and check whether that's the reason?

Also, -14 in testing contains a few fixes.

Michael

  reply	other threads:[~2015-09-04 13:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04  0:04 git grep broken in Fedora 21 update? Rustad, Mark D
2015-09-04  4:55 ` Jacob Keller
2015-09-04 13:34   ` Michael J Gruber [this message]
2015-09-04 14:03 ` Jeff King
2015-09-04 16:18   ` Rustad, Mark D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E99DDC.2000900@drmicha.warpmail.net \
    --to=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=jacob.keller@gmail.com \
    --cc=mark.d.rustad@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).