From: Alan Clucas <alan.clucas@teamwpc.co.uk>
To: Jeff King <peff@peff.net>
Cc: "Øystein Walle" <oystwa@gmail.com>,
"Mark Levedahl" <mlevedahl@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Pass amend to pre-commit hook
Date: Mon, 14 Sep 2015 17:49:17 +0100 [thread overview]
Message-ID: <55F6FA8D.6030509@teamwpc.co.uk> (raw)
In-Reply-To: <20150914144727.GA25003@sigill.intra.peff.net>
On 14/09/15 15:47, Jeff King wrote:
> On Mon, Sep 14, 2015 at 01:14:20PM +0100, Alan Clucas wrote:
>
>> Pass a single parameter 'amend' to the pre-commit hook when performing a
>> commit amend.
>
> I think this is a sensible thing to want, and it has come up a few
> times. I'm not sure why the last round didn't get merged, though. Looks
> like it just slipped through the cracks.
>
> Here are the relevant threads:
>
> http://thread.gmane.org/gmane.comp.version-control.git/260122
>
> http://thread.gmane.org/gmane.comp.version-control.git/260245
>
> Looks like there was some question of what to pass in the normal,
> non-amend case. I've added interested parties from the original thread
> to the cc here.
>
> -Peff
>
Ah thanks. My google-fu didn't find any of those threads, I should have
tried specifically searching the archives I guess.
Maybe with a little cajoling we could get some version of this passed.
The issue that came up before was my worry, I didn't like defining the
interface that way in case it needed extending... (but other hooks also
have bad interfaces, so wasn't sure what precedent to follow).
Alan
next prev parent reply other threads:[~2015-09-14 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 12:14 [PATCH] Pass amend to pre-commit hook Alan Clucas
2015-09-14 14:47 ` Jeff King
2015-09-14 16:49 ` Alan Clucas [this message]
2015-09-27 22:09 ` Øystein Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F6FA8D.6030509@teamwpc.co.uk \
--to=alan.clucas@teamwpc.co.uk \
--cc=git@vger.kernel.org \
--cc=mlevedahl@gmail.com \
--cc=oystwa@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).