Git development
 help / color / mirror / Atom feed
From: Federico Fissore <federico@fissore.org>
To: git@vger.kernel.org
Subject: [bug] .git/hooks/commit-msg.sample test is reversed
Date: Tue, 15 Sep 2015 10:43:52 +0200	[thread overview]
Message-ID: <55F7DA48.30104@fissore.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

Hello everyone

In file commit-msg.sample, grep test is reversed. It greps
'^Signed-off-by: '
while it should grep
'Signed-off-by: '

If you run the sample against attached file, it won't complain. Remove 
the ^ and it will work as expected

Regards

Federico

[-- Attachment #2: test.commit.msg --]
[-- Type: text/plain, Size: 103 bytes --]

    Commit message
    
    Signed-off-by: Me <me@example.com>
    Signed-off-by: Me <me@example.com>


             reply	other threads:[~2015-09-15  9:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15  8:43 Federico Fissore [this message]
2015-09-15  9:10 ` [bug] .git/hooks/commit-msg.sample test is reversed Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F7DA48.30104@fissore.org \
    --to=federico@fissore.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox