From: Liam Beguin <liambeguin@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, gitster@pobox.com, houstonfortney@gmail.com,
kostix+git@007spb.ru, sxlijin@gmail.com
Subject: Re: [PATCH 0/3] add stash count information to git-status command
Date: Fri, 16 Jun 2017 08:47:51 -0400 [thread overview]
Message-ID: <55aed88d-f0ba-0d5a-9dcd-cda137a426b9@gmail.com> (raw)
In-Reply-To: <20170616121642.jqsua5sw2u2iccdf@sigill.intra.peff.net>
Hi,
On 16/06/17 08:16 AM, Jeff King wrote:
> On Fri, Jun 16, 2017 at 12:30:47AM -0400, Liam Beguin wrote:
>
>> As discussed here [*1*], this allows `git status` to show the number of
>> entries currently stashed away.
>>
>> I also tried to update the related parts of the documentation to use
>> 'stash entry' instead of 'stash' as we agreed that it was a bit better.
>> I don't mind dropping the documentation update and using something like
>> "You have %d stash/stashes" in the status message if it makes the change
>> "too big".
>
> I like the overall direction (including the documentation update). I
> noted a few minor problems in the various patches, though.
Thanks for reviewing! I'll try to send an update later today.
>
> -Peff
>
- Liam
next prev parent reply other threads:[~2017-06-16 12:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 4:30 [PATCH 0/3] add stash count information to git-status command Liam Beguin
2017-06-16 4:30 ` [PATCH 1/3] stash: update documentation to use 'stash entries' Liam Beguin
2017-06-16 12:06 ` Jeff King
2017-06-16 21:24 ` Junio C Hamano
2017-06-16 4:30 ` [PATCH 2/3] wt-status: add optional stash status information Liam Beguin
2017-06-16 12:14 ` Jeff King
2017-06-16 21:29 ` Junio C Hamano
2017-06-16 4:30 ` [PATCH 3/3] glossary: define stash entries Liam Beguin
2017-06-16 12:16 ` Jeff King
2017-06-16 12:16 ` [PATCH 0/3] add stash count information to git-status command Jeff King
2017-06-16 12:47 ` Liam Beguin [this message]
2017-06-17 22:30 ` [PATCH v2 " Liam Beguin
2017-06-17 22:30 ` [PATCH v2 1/3] stash: update documentation to use 'stash entry' Liam Beguin
2017-06-17 22:30 ` [PATCH v2 2/3] status: add optional stash count information Liam Beguin
2017-06-17 22:30 ` [PATCH v2 3/3] glossary: define 'stash entry' Liam Beguin
2017-06-19 5:18 ` [PATCH v2 0/3] add stash count information to git-status command Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55aed88d-f0ba-0d5a-9dcd-cda137a426b9@gmail.com \
--to=liambeguin@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=houstonfortney@gmail.com \
--cc=kostix+git@007spb.ru \
--cc=peff@peff.net \
--cc=sxlijin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).