git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Erick Mattos <erick.mattos@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Changed timestamp behavior of options -c/-C/--amend
Date: Fri, 30 Oct 2009 20:20:55 -0200	[thread overview]
Message-ID: <55bacdd30910301520h2678d0c2hd8478716d8ce4a17@mail.gmail.com> (raw)
In-Reply-To: <7viqdwilx2.fsf@alter.siamese.dyndns.org>

2009/10/30 Junio C Hamano <gitster@pobox.com>:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> ...
>> I agree that the issue the patch addresses is worth improving, and I think
>> it is sensible to default to reuse the timestamp for -C and not to reuse
>> for --amend.  I am not sure about -c myself, but it probably shouldn't
>> reuse the timestamp by default.
>
> So after realizing that this was about "author" timestamp, I am rescinding
> this comment about the change of the default for -c and --amend.

Actually I am only changing the default for -c and I see it useful.
At least with me I normally use -c only to use messages of commits as
template.

> But everything else still stands.  IOW, I still (1) do think the issue is
> worth addressing (thanks Erick), (2) the log message can be improved, and
> (3) --(old|new)-timestamp should be --[no-]reuse-timestamp.
>
(1) You are very welcome! :-)
(2) As you demand.
(3) I prefer the other way just because of saving some typing and
being more concise in my point of view.  But you know you decide it.

  reply	other threads:[~2009-10-30 22:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-30 19:36 [PATCH] Changed timestamp behavior of options -c/-C/--amend Erick Mattos
2009-10-30 20:26 ` Jeff King
2009-10-30 21:22   ` Erick Mattos
2009-10-30 21:51   ` Junio C Hamano
2009-10-30 22:10   ` Johannes Sixt
2009-10-31 23:34   ` Paolo Bonzini
2009-10-30 21:34 ` Junio C Hamano
2009-10-30 21:58   ` Junio C Hamano
2009-10-30 22:20     ` Erick Mattos [this message]
2009-10-30 22:33       ` Junio C Hamano
2009-10-30 23:12         ` Erick Mattos
2009-10-31  0:10           ` Junio C Hamano
2009-10-31  1:42             ` Erick Mattos
     [not found]   ` <55bacdd30910301505xe712b74m837dc862a6ee953@mail.gmail.com>
2009-10-30 22:13     ` Erick Mattos
2009-10-30 22:26       ` Junio C Hamano
2009-10-30 22:30         ` Erick Mattos
2009-10-30 21:56 ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55bacdd30910301520h2678d0c2hd8478716d8ce4a17@mail.gmail.com \
    --to=erick.mattos@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).