From: Erick Mattos <erick.mattos@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Changed timestamp behavior of options -c/-C/--amend
Date: Fri, 30 Oct 2009 20:30:40 -0200 [thread overview]
Message-ID: <55bacdd30910301530n5ce39e03la417685bf02ad50@mail.gmail.com> (raw)
In-Reply-To: <7v8wesh61b.fsf@alter.siamese.dyndns.org>
2009/10/30 Junio C Hamano <gitster@pobox.com>:
> Erick Mattos <erick.mattos@gmail.com> writes:
>
>> 2009/10/30 Junio C Hamano <gitster@pobox.com>:
>>
>>>(besides, you write logs as if you are making
>>> an order to the codebase to "do this!").
>>
>> Not a chance! Just trying to help.
>
> Sorry, you misunderstood me. What I meant was:
>
> It is customery for us to write our log messages as if the author of
> the patch is giving an order, iow, in imperative mood. Your "Changed
> blah" violates that style.
>
I got it in the opposite way. :-D
So one should give an "order"!... :-1
next prev parent reply other threads:[~2009-10-30 22:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-30 19:36 [PATCH] Changed timestamp behavior of options -c/-C/--amend Erick Mattos
2009-10-30 20:26 ` Jeff King
2009-10-30 21:22 ` Erick Mattos
2009-10-30 21:51 ` Junio C Hamano
2009-10-30 22:10 ` Johannes Sixt
2009-10-31 23:34 ` Paolo Bonzini
2009-10-30 21:34 ` Junio C Hamano
2009-10-30 21:58 ` Junio C Hamano
2009-10-30 22:20 ` Erick Mattos
2009-10-30 22:33 ` Junio C Hamano
2009-10-30 23:12 ` Erick Mattos
2009-10-31 0:10 ` Junio C Hamano
2009-10-31 1:42 ` Erick Mattos
[not found] ` <55bacdd30910301505xe712b74m837dc862a6ee953@mail.gmail.com>
2009-10-30 22:13 ` Erick Mattos
2009-10-30 22:26 ` Junio C Hamano
2009-10-30 22:30 ` Erick Mattos [this message]
2009-10-30 21:56 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55bacdd30910301530n5ce39e03la417685bf02ad50@mail.gmail.com \
--to=erick.mattos@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).