From: Erick Mattos <erick.mattos@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] commit -c/-C/--amend: acquire authorship and restamp time with --claim
Date: Sun, 1 Nov 2009 22:54:34 -0200 [thread overview]
Message-ID: <55bacdd30911011654k22eb6b13r28897bf71fc5e11b@mail.gmail.com> (raw)
In-Reply-To: <7vbpjlycqc.fsf@alter.siamese.dyndns.org>
2009/11/1 Junio C Hamano <gitster@pobox.com>:
> Erick Mattos <erick.mattos@gmail.com> writes:
>
>>> % git commit --claim --author='Erick Mattos <eric@mattos>' -C HEAD
>>>
>>> Should you detect an error? Does your code do so? Do you have a test
>>> that catches this error?
>>
>> It works as intended. Both together.
>
> That does not make any sense. If you are saying this is yours and it is
> his at the same time, there can be no sane way to work "as intended", no?.
I am adding a new option not changing the option --author already in
git. So it does work together.
>>>> + git commit -c HEAD <<EOF
>>>> + "Changed"
>>>> + EOF &&
>>>
>>> What editor is reading this "Changed"?
>>
>> Nobody cares... Just a text to change the file.
>
> I actually care. Who uses that Changed string, and where does it end up
> with? At the end of the log message? At the beginning? What "file"?
>
I didn't get it. -c option does not accept -m option and starts an
editor to change the message. The text "Changed is just a forced
message. I can not use an editor in interactive mode in a script...
What I am losing here??
next prev parent reply other threads:[~2009-11-02 0:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 3:08 [PATCH] commit -c/-C/--amend: take over authorship and restamp time with --claim Erick Mattos
2009-10-31 21:24 ` Junio C Hamano
2009-11-01 18:19 ` [PATCH v2] " Erick Mattos
2009-11-01 18:45 ` [PATCH] commit -c/-C/--amend: acquire " Erick Mattos
2009-11-01 20:02 ` Junio C Hamano
2009-11-01 20:57 ` Erick Mattos
2009-11-02 0:47 ` Junio C Hamano
2009-11-02 0:54 ` Erick Mattos [this message]
2009-11-02 2:58 ` Junio C Hamano
2009-11-02 3:07 ` Junio C Hamano
2009-11-03 16:39 ` Erick Mattos
2009-11-01 23:14 ` Erick Mattos
2009-11-02 0:44 ` [PATCH] commit -c/-C/--amend: reset timestamp and authorship to committer with --mine Erick Mattos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55bacdd30911011654k22eb6b13r28897bf71fc5e11b@mail.gmail.com \
--to=erick.mattos@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).