From: "Martin Ågren" <martin.agren@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 1/2] t1517: add missing LIBCURL prereq
Date: Wed, 11 Sep 2024 12:30:59 +0200 [thread overview]
Message-ID: <55d45be1d6775a630b9f61487b6b60efab9c7769.1726049108.git.martin.agren@gmail.com> (raw)
In-Reply-To: <cover.1726049108.git.martin.agren@gmail.com>
After building Git with NO_LIBCURL, there is no `git remote-http`, so
it's not meaningful to test that it can run outside of a repository.
Indeed, that test will fail. Add the LIBCURL prereq to it.
Signed-off-by: Martin Ågren <martin.agren@gmail.com>
---
This is from b25ec8b8d5 (t1517: more coverage for commands that work
without repository, 2024-05-31), which first appeared in 2.46.0.
t/t1517-outside-repo.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh
index 990a036582..342defbb61 100755
--- a/t/t1517-outside-repo.sh
+++ b/t/t1517-outside-repo.sh
@@ -98,7 +98,7 @@ test_expect_success 'stripspace outside repository' '
nongit git stripspace -s </dev/null
'
-test_expect_success 'remote-http outside repository' '
+test_expect_success LIBCURL 'remote-http outside repository' '
test_must_fail git remote-http 2>actual &&
test_grep "^error: remote-curl" actual &&
(
--
2.46.0.733.g1eb83ef1a1
next prev parent reply other threads:[~2024-09-11 10:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 10:30 [PATCH 0/2] add missing LIBCURL prereq to a few tests Martin Ågren
2024-09-11 10:30 ` Martin Ågren [this message]
2024-09-11 10:31 ` [PATCH 2/2] t0211: add missing LIBCURL prereq Martin Ågren
2024-09-11 15:53 ` [PATCH 0/2] add missing LIBCURL prereq to a few tests Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55d45be1d6775a630b9f61487b6b60efab9c7769.1726049108.git.martin.agren@gmail.com \
--to=martin.agren@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).