From: Luke Diamand <luke@diamand.org>
To: larsxschneider@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH v3] git-p4: use replacement character for non UTF-8 characters in paths
Date: Mon, 21 Sep 2015 20:34:53 +0100 [thread overview]
Message-ID: <56005BDD.6050508@diamand.org> (raw)
In-Reply-To: <1442825358-90294-1-git-send-email-larsxschneider@gmail.com>
On 21/09/15 09:49, larsxschneider@gmail.com wrote:
> From: Lars Schneider <larsxschneider@gmail.com>
>
> I broke a test in "[PATCH v2] git-p4: improve path encoding verbose output" on the next branch.
> This patch on top of next (3dd15c0) fixes the issue.
>
> Thanks to Luke for finding the issue!
Looks good to me, apart from using a UTF-8 char in the comment itself,
which seems a bit unnecessary. Imagine what will happen to someone using
git-p4 to mirror git-p4 itself into p4!
>
> Cheers,
> Lars
>
> Lars Schneider (1):
> git-p4: use replacement character for non UTF-8 characters in paths
>
> git-p4.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.5.1
>
next prev parent reply other threads:[~2015-09-21 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 8:49 [PATCH v3] git-p4: use replacement character for non UTF-8 characters in paths larsxschneider
2015-09-21 8:49 ` larsxschneider
2015-09-21 19:34 ` Luke Diamand [this message]
2015-09-21 20:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56005BDD.6050508@diamand.org \
--to=luke@diamand.org \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).