From: Thomas Rast <trast@student.ethz.ch>
To: <git@vger.kernel.org>
Cc: "Johannes Schindelin" <johannes.schindelin@gmx.de>,
"Jeff King" <peff@peff.net>, "Carlos Martín Nieto" <cmn@elego.de>,
"Thomas Rast" <trast@inf.ethz.ch>
Subject: [PATCH 3/3] tests --valgrind: provide a mode without --track-origins
Date: Sun, 31 Mar 2013 10:00:17 +0200 [thread overview]
Message-ID: <560f4d3cedf1cf32331f864bae94124c02495c06.1364716452.git.trast@inf.ethz.ch> (raw)
In-Reply-To: <cover.1364716452.git.trast@inf.ethz.ch>
From: Thomas Rast <trast@inf.ethz.ch>
With --valgrind=memcheck-fast, the tests run under memcheck but
without the autodetected --track-origins. If you just run valgrind to
see *if* there is any memory issue with your program, the extra
information is not needed, and it comes at a roughly 30% hit in
runtime.
While it is possible to achieve the same through GIT_VALGRIND_OPTIONS,
this should be more discoverable and hopefully encourage more users to
run their tests with valgrind.
Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
---
t/README | 5 +++++
t/valgrind/valgrind.sh | 2 ++
2 files changed, 7 insertions(+)
diff --git a/t/README b/t/README
index f5ee40f..9b41fe7 100644
--- a/t/README
+++ b/t/README
@@ -106,6 +106,11 @@ appropriately before running "make".
'drd', but you may use any tool recognized by your valgrind
installation.
+ As a special case, <tool> can be 'memcheck-fast', which uses
+ memcheck but disables --track-origins. Use this if you are
+ running tests in bulk, to see if there are _any_ memory
+ issues.
+
Note that memcheck is run with the option --leak-check=no,
as the git process is short-lived and some errors are not
interesting. In order to run a single command under the same
diff --git a/t/valgrind/valgrind.sh b/t/valgrind/valgrind.sh
index 472ac2d..6b87c91 100755
--- a/t/valgrind/valgrind.sh
+++ b/t/valgrind/valgrind.sh
@@ -5,6 +5,8 @@ base=$(basename "$0")
TOOL_OPTIONS='--leak-check=no'
case "$GIT_VALGRIND_MODE" in
+memcheck-fast)
+ ;;
memcheck)
VALGRIND_VERSION=$(valgrind --version)
VALGRIND_MAJOR=$(expr "$VALGRIND_VERSION" : '[^0-9]*\([0-9]*\)')
--
1.8.2.467.gedf93a5
next prev parent reply other threads:[~2013-03-31 8:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-31 8:00 [PATCH 0/3] tests: --valgrind=tool Thomas Rast
2013-03-31 8:00 ` [PATCH 1/3] t/README: --valgrind already implies -v Thomas Rast
2013-03-31 8:00 ` [PATCH 2/3] tests: parameterize --valgrind option Thomas Rast
2013-03-31 8:00 ` Thomas Rast [this message]
2013-03-31 8:37 ` [PATCH 3/4] tests: notice valgrind error in test_must_fail Thomas Rast
2013-04-01 14:27 ` [PATCH 0/3] tests: --valgrind=tool Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560f4d3cedf1cf32331f864bae94124c02495c06.1364716452.git.trast@inf.ethz.ch \
--to=trast@student.ethz.ch \
--cc=cmn@elego.de \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).