From: Michael Haggerty <mhagger@alum.mit.edu>
To: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Cc: "Jeff King" <peff@peff.net>, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH v3 01/13] refs: convert some internal functions to use object_id
Date: Tue, 13 Oct 2015 13:43:30 +0200 [thread overview]
Message-ID: <561CEE62.4030403@alum.mit.edu> (raw)
In-Reply-To: <1444355039-186351-2-git-send-email-sandals@crustytoothpaste.net>
On 10/09/2015 03:43 AM, brian m. carlson wrote:
> Convert several internal functions in refs.c to use struct object_id,
> and use the GIT_SHA1_HEXSZ constants in parse_ref_line.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> [...]
I looked over this patch at the diff level and didn't find any problems.
This patch conflicts heavily with [1]. But I noticed that it is
independent of the rest of your series. I don't know when either patch
series will be ready, but see [2] for my take on the other one.
Assuming neither series is rejected, I think it would be much easier to
redo this patch on top of the first part of [1] than vice versa, so that
would be my suggestion. If it comes down to that, I am willing to help
redo this patch if you like.
Michael
[1] http://thread.gmane.org/gmane.comp.version-control.git/279423
[2] http://article.gmane.org/gmane.comp.version-control.git/279496
--
Michael Haggerty
mhagger@alum.mit.edu
next prev parent reply other threads:[~2015-10-13 11:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 1:43 [PATCH v3 00/13] object_id part 2 brian m. carlson
2015-10-09 1:43 ` [PATCH v3 01/13] refs: convert some internal functions to use object_id brian m. carlson
2015-10-13 11:43 ` Michael Haggerty [this message]
2015-10-14 2:50 ` brian m. carlson
2015-10-09 1:43 ` [PATCH v3 02/13] sha1_file: introduce has_object_file helper brian m. carlson
2015-10-09 1:43 ` [PATCH v3 03/13] Convert struct ref to use object_id brian m. carlson
2015-10-09 1:43 ` [PATCH v3 04/13] add_sought_entry_mem: convert to struct object_id brian m. carlson
2015-10-09 1:43 ` [PATCH v3 05/13] parse_fetch: convert to use " brian m. carlson
2015-10-09 1:43 ` [PATCH v3 06/13] get_remote_heads: convert to " brian m. carlson
2015-10-09 1:43 ` [PATCH v3 07/13] push_refs_with_export: " brian m. carlson
2015-10-09 1:43 ` [PATCH v3 08/13] ref_newer: convert to use " brian m. carlson
2015-10-09 1:43 ` [PATCH v3 09/13] object: introduce get_object_hash macro brian m. carlson
2015-10-09 1:43 ` [PATCH v3 10/13] Add several uses of get_object_hash brian m. carlson
2015-10-09 1:43 ` [PATCH v3 11/13] Convert struct object to object_id brian m. carlson
2015-10-09 1:43 ` [PATCH v3 12/13] Remove get_object_hash brian m. carlson
2015-10-09 1:43 ` [PATCH v3 13/13] remote: convert functions to struct object_id brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561CEE62.4030403@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).