From: Luke Diamand <luke@diamand.org>
To: Lars Schneider <larsxschneider@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v1] git-p4: Add option to ignore empty commits
Date: Sat, 24 Oct 2015 20:07:53 +0100 [thread overview]
Message-ID: <562BD709.1020307@diamand.org> (raw)
In-Reply-To: <C5352225-D67D-4ECD-83DB-D5E5A8ED13A7@gmail.com>
On 24/10/15 17:28, Lars Schneider wrote:
>
>> Also I have this suspicion that those who do want to use client spec
>> to get a narrowed view into the history would almost always want
>> this "ignore empty" behaviour (I'd even say the current behaviour to
>> leave empty commits by default is a bug). What are the advantages
>> of keeping empty commits? If there aren't many, perhaps git-p4
>> should by the default skip empties and require p4.keepEmpty
>> configuration to keep them?
>
> I agree.
> @Luke: What option do you prefer? "git-p4.keepEmptyCommits" or "git-p4.ignoreEmptyCommits" ?
keepEmptyCommits.
next prev parent reply other threads:[~2015-10-24 19:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 18:43 [PATCH v1] git-p4: Add option to ignore empty commits larsxschneider
2015-10-20 17:27 ` Junio C Hamano
2015-10-24 16:28 ` Lars Schneider
2015-10-24 19:07 ` Luke Diamand [this message]
2015-10-21 6:32 ` Luke Diamand
2015-10-24 18:08 ` Lars Schneider
2015-10-26 20:40 ` Luke Diamand
2015-10-28 22:35 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562BD709.1020307@diamand.org \
--to=luke@diamand.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).