From: Johannes Sixt <j6t@kdbg.org>
To: Stefan Beller <sbeller@google.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Ramsay Jones <ramsay@ramsayjones.plus.com>,
Jacob Keller <jacob.keller@gmail.com>, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmail.com>,
Jens Lehmann <Jens.Lehmann@web.de>,
Eric Sunshine <ericsunshine@gmail.com>
Subject: Re: [PATCH] run-command: detect finished children by closed pipe rather than waitpid
Date: Wed, 11 Nov 2015 21:48:32 +0100 [thread overview]
Message-ID: <5643A9A0.50105@kdbg.org> (raw)
In-Reply-To: <CAGZ79kaZ0W5q8=iowbSTJY_mDNNYc6qdTszcWDDDCtYfZyeK_Q@mail.gmail.com>
Am 11.11.2015 um 21:37 schrieb Stefan Beller:
> including the list and all others this time.
>
>>> if (code < 0) {
>>> pp->shutdown = 1;
>>> - kill_children(pp, SIGTERM);
>>> + kill_children(pp, -code);
>>
>>
>> I'll see what this means for our kill emulation on Windows. Currently, we
>> handle only SIGTERM.
>
> So currently we only pass in SIGTERM from the callers, and I certainly
> only intend
> to use that signal. I just thought special casing the SIGTERM signal
> would do no good
> in terms of design here.
>
> So maybe that was not the right thought and we do have to special case
> SIGTERM here?
I wonder why task_finish() callback gets to choose a signal. The point
here is, IIUC, when one child dies, the others must be halted, too.
SIGTERM seems to be the only sensible choice.
-- Hannes
next prev parent reply other threads:[~2015-11-11 20:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 23:48 [PATCH] run-command: detect finished children by closed pipe rather than waitpid Stefan Beller
2015-11-07 6:28 ` Torsten Bögershausen
2015-11-07 9:01 ` Johannes Sixt
2015-11-11 20:37 ` Stefan Beller
2015-11-11 20:48 ` Johannes Sixt [this message]
2015-11-11 20:53 ` Stefan Beller
2015-11-11 22:18 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5643A9A0.50105@kdbg.org \
--to=j6t@kdbg.org \
--cc=Jens.Lehmann@web.de \
--cc=ericsunshine@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
--cc=johannes.schindelin@gmail.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).