git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>,
	Eric Sunshine <sunshine@sunshineco.com>
Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
	GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] http: fix some printf format warnings on 32-bit builds
Date: Thu, 12 Nov 2015 06:27:08 +0100	[thread overview]
Message-ID: <5644232C.2060700@web.de> (raw)
In-Reply-To: <5643ABF0.5080207@ramsayjones.plus.com>

 >Ah. OK, so %ld for long and %lld for long long, I suppose. Only if you 
have a system that's support it.

Linux does, Windows not.

>Hmm, not that it matters, but I wonder what the PRId64 macro is. ;-)
It's "I64d" for Windows, and "lld" for all Gnu based systems and others,

When you do printf("%lld %ld", long_long_var, long_var),
the "printf runtime" under Windows will treat "%lld" as "%ld", and print
the lower part of long_long_var.
And will not pull a long long from stack, but a long, resulting i all kinds of confusion

So whenever a long long is printed, I can warmly recommend to use

PRId64

  reply	other threads:[~2015-11-12  5:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11  0:23 [PATCH] http: fix some printf format warnings on 32-bit builds Ramsay Jones
2015-11-11  1:22 ` Eric Sunshine
2015-11-11  2:00   ` Stefan Beller
2015-11-11  8:02     ` Lars Schneider
2015-11-11 17:38       ` Stefan Beller
2015-11-11 17:49     ` Ramsay Jones
2015-11-13  8:46       ` Lars Schneider
2015-11-13  8:57         ` Eric Sunshine
2015-11-13 10:32           ` Torsten Bögershausen
2015-11-13 12:08             ` Lars Schneider
2015-11-13 20:02           ` Ramsay Jones
2015-11-14 19:14             ` Lars Schneider
2015-11-11 17:47   ` Ramsay Jones
2015-11-11 20:31     ` Eric Sunshine
2015-11-11 20:54       ` Jeff King
2015-11-11 20:58       ` Ramsay Jones
2015-11-12  5:27         ` Torsten Bögershausen [this message]
2015-11-12 11:58           ` Ramsay Jones
2015-11-12 18:40           ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5644232C.2060700@web.de \
    --to=tboegi@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=ramsay@ramsayjones.plus.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).