From: Luke Diamand <luke@diamand.org>
To: Eric Sunshine <sunshine@sunshineco.com>,
Lars Schneider <larsxschneider@gmail.com>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout
Date: Tue, 17 Nov 2015 09:34:04 +0000 [thread overview]
Message-ID: <564AF48C.9040406@diamand.org> (raw)
In-Reply-To: <CAPig+cR8igO1bWNgma_yZqrcru_jnKchpRH+i2_AaNj8Atcb9g@mail.gmail.com>
>>
>> While implementing it I thought more about it. P4D is only
>> supported on platforms that support the date function. That means
>> these tests will only run on platforms that support the date
>> function. Consequently I wondered if this would justify the
>> slightly more complicated code. However, if you think this change
>> would help the patch to get accepted then I will add it.
>
> I don't feel strongly about it, and it's not my call anyhow. Opinions
> of Junio, Peff (as interim maintainer), and Luke weigh much more
> heavily than my own. Punting on dynamic detection of "date +%s" may be
> perfectly acceptable with the attitude that it can be implemented
> later if someone runs across a case where it's actually needed.
Which other platforms are we talking about here?
https://www.perforce.com/downloads/helix
From there, you can get Solaris10, HP-UX, AIX and various flavours of
BSD. Solaris supports "date +%s".
HP-UX and AIX, I really don't know.
Windows? I assume 'date +%s' will work for people using mingw.
Is it possible to get the time in seconds by doing something like this:
time_in_seconds() {
python -c 'import time; print time.time()'
}
Luke
next prev parent reply other threads:[~2015-11-17 9:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-15 13:08 [PATCH v5 0/6] Add Travis CI support larsxschneider
2015-11-15 13:08 ` [PATCH v5 1/6] implement test_might_fail using a refactored test_must_fail larsxschneider
2015-11-15 13:08 ` [PATCH v5 2/6] add "ok=sigpipe" to test_must_fail and use it to fix flaky tests larsxschneider
2015-11-15 13:08 ` [PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout larsxschneider
2015-11-16 8:36 ` Luke Diamand
2015-11-17 8:22 ` Lars Schneider
2015-11-17 9:38 ` Luke Diamand
2015-11-16 21:14 ` Eric Sunshine
2015-11-17 8:28 ` Lars Schneider
2015-11-17 8:35 ` Eric Sunshine
2015-11-17 9:34 ` Luke Diamand [this message]
2015-11-17 17:44 ` Eric Sunshine
2015-11-17 23:40 ` Luke Diamand
2015-11-15 13:08 ` [PATCH v5 4/6] git-p4: add p4d timeout in tests larsxschneider
2015-11-16 8:39 ` Luke Diamand
2015-11-15 13:08 ` [PATCH v5 5/6] git-p4: add trap to kill p4d on test exit larsxschneider
2015-11-16 8:43 ` Luke Diamand
2015-11-17 8:29 ` Lars Schneider
2015-11-15 13:08 ` [PATCH v5 6/6] Add Travis CI support larsxschneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564AF48C.9040406@diamand.org \
--to=luke@diamand.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).