From: Luke Diamand <luke@diamand.org>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: git@vger.kernel.org, sunshine@sunshineco.com, gitster@pobox.com
Subject: Re: [PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout
Date: Tue, 17 Nov 2015 09:38:39 +0000 [thread overview]
Message-ID: <564AF59F.2070601@diamand.org> (raw)
In-Reply-To: <90549E9A-205A-4848-B794-23E44F325F1E@gmail.com>
On 17/11/15 08:22, Lars Schneider wrote:
>
> On 16 Nov 2015, at 09:36, Luke Diamand <luke@diamand.org> wrote:
>
>> On 15/11/15 13:08, larsxschneider@gmail.com wrote:
>>> From: Lars Schneider <larsxschneider@gmail.com>
>>>
>>> In rare cases kill/cleanup operations in tests fail. Retry these
>>> operations with a timeout to make the test less flaky.
>>
>> Should there be a sleep in that retry_until_success loop so that it doesn't spin sending signals to p4d?
> Agreed. I will add a sleep in the next roll!
>
>
>>
>> Do we need to worry about the time offset being updated (e.g. NTP) while this is running?
> Interesting question! I would consider this an edge case but I can see how it could happen.
> Do you see a way to handle that in an easy way?
>
You want to somehow call clock_gettime(CLOCK_MONOTONIC). That's not in
python until 3.3. Writing a C program seems like overkill but could be a
solution if this becomes a problem.
next prev parent reply other threads:[~2015-11-17 9:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-15 13:08 [PATCH v5 0/6] Add Travis CI support larsxschneider
2015-11-15 13:08 ` [PATCH v5 1/6] implement test_might_fail using a refactored test_must_fail larsxschneider
2015-11-15 13:08 ` [PATCH v5 2/6] add "ok=sigpipe" to test_must_fail and use it to fix flaky tests larsxschneider
2015-11-15 13:08 ` [PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout larsxschneider
2015-11-16 8:36 ` Luke Diamand
2015-11-17 8:22 ` Lars Schneider
2015-11-17 9:38 ` Luke Diamand [this message]
2015-11-16 21:14 ` Eric Sunshine
2015-11-17 8:28 ` Lars Schneider
2015-11-17 8:35 ` Eric Sunshine
2015-11-17 9:34 ` Luke Diamand
2015-11-17 17:44 ` Eric Sunshine
2015-11-17 23:40 ` Luke Diamand
2015-11-15 13:08 ` [PATCH v5 4/6] git-p4: add p4d timeout in tests larsxschneider
2015-11-16 8:39 ` Luke Diamand
2015-11-15 13:08 ` [PATCH v5 5/6] git-p4: add trap to kill p4d on test exit larsxschneider
2015-11-16 8:43 ` Luke Diamand
2015-11-17 8:29 ` Lars Schneider
2015-11-15 13:08 ` [PATCH v5 6/6] Add Travis CI support larsxschneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564AF59F.2070601@diamand.org \
--to=luke@diamand.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).