From: Luke Diamand <luke@diamand.org>
To: larsxschneider@gmail.com, git@vger.kernel.org
Cc: sunshine@sunshineco.com, gitster@pobox.com, peff@peff.net
Subject: Re: [PATCH v6 0/6] Add Travis CI support
Date: Mon, 23 Nov 2015 21:19:16 +0000 [thread overview]
Message-ID: <565382D4.5010200@diamand.org> (raw)
In-Reply-To: <1447923491-15330-1-git-send-email-larsxschneider@gmail.com>
On 19/11/15 08:58, larsxschneider@gmail.com wrote:
> From: Lars Schneider <larsxschneider@gmail.com>
>
> diff to v5:
> * check if PID file still exists on P4D cleanup (thanks Luke)
> * fix space/tab formatting error
> * add sleep to timeout loops (thanks Luke)
> * replace 'date +%s' with platform independent Python function (thanks Eric and Luke)
The first three of these (which fix the git-p4 tests) all look good to
me. With these changes, running the t98* tests in parallel now works,
which it did not used to do. The changes are not pretty but I think
that's inevitable.
Ack from me.
Luke
prev parent reply other threads:[~2015-11-23 21:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 8:58 [PATCH v6 0/6] Add Travis CI support larsxschneider
2015-11-19 8:58 ` [PATCH v6 1/6] implement test_might_fail using a refactored test_must_fail larsxschneider
2015-11-19 8:58 ` [PATCH v6 2/6] add "ok=sigpipe" to test_must_fail and use it to fix flaky tests larsxschneider
2015-11-19 8:58 ` [PATCH v6 3/6] git-p4: retry kill/cleanup operations in tests with timeout larsxschneider
2015-11-19 8:58 ` [PATCH v6 4/6] git-p4: add p4d timeout in tests larsxschneider
2015-11-19 8:58 ` [PATCH v6 5/6] git-p4: add trap to kill p4d on test exit larsxschneider
2015-11-19 8:58 ` [PATCH v6 6/6] Add Travis CI support larsxschneider
2015-11-19 14:35 ` Jeff King
2015-11-20 9:29 ` Lars Schneider
2015-11-19 14:14 ` [PATCH v6 0/6] " Jeff King
2015-11-20 8:46 ` Lars Schneider
2015-11-20 12:56 ` Luke Diamand
2015-11-23 18:59 ` Jeff King
2015-11-23 21:19 ` Luke Diamand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565382D4.5010200@diamand.org \
--to=luke@diamand.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).