From: "Torsten Bögershausen" <tboegi@web.de>
To: Edmundo Carmona Antoranz <eantoranz@gmail.com>, git@vger.kernel.org
Cc: gitster@pobox.com, j6t@kdbg.org
Subject: Re: [PATCH v4] blame: add support for --[no-]progress option
Date: Tue, 24 Nov 2015 06:57:33 +0100 [thread overview]
Message-ID: <5653FC4D.4090201@web.de> (raw)
In-Reply-To: <1448327277-29385-1-git-send-email-eantoranz@gmail.com>
On 11/24/2015 02:07 AM, Edmundo Carmona Antoranz wrote:
> diff --git a/builtin/blame.c b/builtin/blame.c
> index 83612f5..1d43b52 100644
> --- a/builtin/blame.c
> +++ b/builtin/blame.c
> @@ -28,6 +28,7 @@
> #include "line-range.h"
> #include "line-log.h"
> #include "dir.h"
> +#include "progress.h"
>
> static char blame_usage[] = N_("git blame [<options>] [<rev-opts>] [<rev>] [--] <file>");
>
> @@ -50,6 +51,7 @@ static int incremental;
> static int xdl_opts;
> static int abbrev = -1;
> static int no_whole_file_rename;
> +static int show_progress;
>
> static struct date_mode blame_date_mode = { DATE_ISO8601 };
> static size_t blame_date_width;
> @@ -127,6 +129,11 @@ struct origin {
> char path[FLEX_ARRAY];
> };
>
> +struct progress_info {
> + struct progress *progress;
> + int blamed_lines;
> +};
> +
> static int diff_hunks(mmfile_t *file_a, mmfile_t *file_b, long ctxlen,
> xdl_emit_hunk_consume_func_t hunk_func, void *cb_data)
> {
> @@ -1746,7 +1753,8 @@ static int emit_one_suspect_detail(struct origin *suspect, int repeat)
> * The blame_entry is found to be guilty for the range.
> * Show it in incremental output.
> */
> -static void found_guilty_entry(struct blame_entry *ent)
> +static void found_guilty_entry(struct blame_entry *ent,
> + struct progress_info * pi)
Minor remark: The '*' should be close to the variable: "struct
progress_info *pi"
>
next prev parent reply other threads:[~2015-11-24 5:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 1:07 [PATCH v4] blame: add support for --[no-]progress option Edmundo Carmona Antoranz
2015-11-24 1:10 ` Edmundo Carmona Antoranz
2015-11-24 5:57 ` Torsten Bögershausen [this message]
2015-11-25 4:33 ` Edmundo Carmona Antoranz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5653FC4D.4090201@web.de \
--to=tboegi@web.de \
--cc=eantoranz@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).