From: Victor Leschuk <vleschuk@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Git List" <git@vger.kernel.org>,
"Victor Leschuk" <vleschuk@accesssoftek.com>,
"Junio C Hamano" <gitster@pobox.com>,
"John Keeping" <john@keeping.me.uk>, "Jeff King" <peff@peff.net>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH v7] Add git-grep threads param
Date: Sun, 13 Dec 2015 22:25:06 +0300 [thread overview]
Message-ID: <566DC612.60409@gmail.com> (raw)
In-Reply-To: <CAPig+cTybb9d4enQjCuAefexcP=rPG2SF3VvvB78SUW1UmkuQw@mail.gmail.com>
Hello Eric:
> Hmm, v7 doesn't seem to address any of the v6 review comments here[1].
> Was that review merely overlooked or did you disagree with the
> reviewer?
>
> [1]: http://article.gmane.org/gmane.comp.version-control.git/281817
Sorry, it looks like I missed that letter. My bad.
>
>> History of changes from the first version ($gmane/280053/:
> It's generally more helpful to reviewers if you provide a link to the
> previous version and describe the changes since that version. (If you
> prefer, it's also okay to describe all changes, but they should be
> organized by version so that it's obvious which changes were made in
> which version.)
I will prepare v8 and list changes starting from v6. Please kindly
disregard this one.
prev parent reply other threads:[~2015-12-13 19:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 15:17 [PATCH v7] Add git-grep threads param Victor Leschuk
2015-12-13 19:13 ` Eric Sunshine
2015-12-13 19:25 ` Victor Leschuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566DC612.60409@gmail.com \
--to=vleschuk@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
--cc=vleschuk@accesssoftek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).