From: "Torsten Bögershausen" <tboegi@web.de>
To: Junio C Hamano <gitster@pobox.com>, tboegi@web.de
Cc: git@vger.kernel.org
Subject: Re: [PATCH v11] ls-files: add eol diagnostics
Date: Fri, 15 Jan 2016 05:51:35 +0100 [thread overview]
Message-ID: <56987AD7.2050707@web.de> (raw)
In-Reply-To: <xmqqr3hkj6q1.fsf@gitster.mtv.corp.google.com>
On 01/14/2016 08:34 PM, Junio C Hamano wrote:
(OK with the rest of the comments, thanks)
> + return "binary";
> It is true and correct that we do not do EOL conversion on text
> files that have a lone CR, but I think it is misleading to tell the
> users that such files are "binary". We do not refrain from showing
> the textual diff for such files, for example.
>
> To put it another way, we do not do EOL conversion for truly
> 'binary' files, but there are (mostly) text files that are not
> binary that we do not do EOL conversion on. And you want to tell
> the user if EOL conversion would happen to each file. It is not
> correct to label "this file is binary" merely because you do not do
> EOL conversion. Perhaps define a new "literal" class that is a
> superset of "binary" and use that as the label? I am not suggesting
> that "ls-files --eol" should show "i/binary" for truly binary files
> and "i/literal" for a non-binary file with lone CRs. For the
> purpose of "--eol", you only care about "literal", so you do not
> even have to have "binary" class at all.
This makes sense, how about "-text" ?
prev parent reply other threads:[~2016-01-15 4:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 16:17 [PATCH v11] ls-files: add eol diagnostics tboegi
2016-01-14 19:34 ` Junio C Hamano
2016-01-15 4:51 ` Torsten Bögershausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56987AD7.2050707@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).