From: Moritz Neeb <lists@moritzneeb.de>
To: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Replacing strbuf_getline_lf() by strbuf_getline() in wt-status.c
Date: Sat, 30 Jan 2016 15:30:46 +0100 [thread overview]
Message-ID: <56ACC916.8020008@moritzneeb.de> (raw)
Currently I am working on replacing strbuf_getline_lf() by
strbuf_getline() in places where the input is trimmed immediately after
reading, cf. $gmane/284104, "Notes on the remaining strbuf_getline_lf()
callers", 2nd point.
One instance I found was in wt-status.c. In read_rebase_todolist() the
lines are read, checked for a comment_line_char and then trimmed. I
wonder why the input is not trimmed before checking for this character?
Is it safe to replace strbuf_getline_lf() by strbuf_getline() anyway?
The only case I can imagine that could lead to unexpected behaviour then
would be when someone sets the comment_line_char to CR. How likely is that?
Why is the trim after checking for the comment char anyway? Should
something like " # foobar" not be considered as comment?
next reply other threads:[~2016-01-30 14:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 14:30 Moritz Neeb [this message]
2016-01-30 22:49 ` Replacing strbuf_getline_lf() by strbuf_getline() in wt-status.c Moritz Neeb
2016-01-31 16:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56ACC916.8020008@moritzneeb.de \
--to=lists@moritzneeb.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).