git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Strapetz <marc.strapetz@syntevo.com>
To: Jacob Keller <jacob.keller@gmail.com>, Jeff King <peff@peff.net>
Cc: Jens Lehmann <Jens.Lehmann@web.de>,
	Git mailing list <git@vger.kernel.org>
Subject: Re: git submodule should honor "-c credential.helper" command line argument
Date: Wed, 3 Feb 2016 09:08:09 +0100	[thread overview]
Message-ID: <56B1B569.5040502@syntevo.com> (raw)
In-Reply-To: <CA+P7+xq8sv6f8K8K0EEjXg=wdKpFg6z0K5F6P4SGEp+wKdU=rA@mail.gmail.com>

On 03.02.2016 08:35, Jacob Keller wrote:
> On Tue, Feb 2, 2016 at 8:25 PM, Jeff King <peff@peff.net> wrote:
>> I think the problem is that when git "switches" to working in the
>> submodule repository, it clears the environment, which includes any "-c"
>> command switches. This makes sense for some situations, but not for
>> others. This thread shows a similar problem:
>>
>>    http://thread.gmane.org/gmane.comp.version-control.git/264840
>>
>> Jens suggested there adding an option to tell clone to pass specific
>> variables to the submodule, which I think makes sense. AFAIK, nobody has
>> done any work yet on that approach.
>>
>
> This is something that I am also interested in, haven't had a chance
> to look at it just yet though. I may have some time soon to take a
> stab at this.

To have this issue addressed would be great. It's currently preventing 
me to switch our authentication-related code to credential helpers.

Jake, I'm happy to help, if I can (I don't have any experience with Git 
code though, except of browsing it a couple of times ... so patches from 
my side would need a lot of review I guess :). Just let me know.

-Marc

  reply	other threads:[~2016-02-03  8:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 17:13 git submodule should honor "-c credential.helper" command line argument Marc Strapetz
2016-02-03  4:25 ` Jeff King
2016-02-03  7:35   ` Jacob Keller
2016-02-03  8:08     ` Marc Strapetz [this message]
2016-02-03 23:44   ` Jacob Keller
2016-02-07  4:41     ` Jacob Keller
2016-02-07 13:48       ` Marc Strapetz
2016-02-08  3:44         ` Jacob Keller
2016-02-19  1:15           ` Jacob Keller
2016-02-19  4:30             ` Jeff King
2016-02-19  7:29               ` Jacob Keller
2016-02-19  7:46                 ` Jeff King
2016-02-19  7:51                   ` Jacob Keller
2016-02-19 17:33               ` Junio C Hamano
2016-02-19 19:34                 ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B1B569.5040502@syntevo.com \
    --to=marc.strapetz@syntevo.com \
    --cc=Jens.Lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=jacob.keller@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).