From: Kazutoshi Satoda <k_satoda@f2.dion.ne.jp>
To: Eric Wong <normalperson@yhbt.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] tests: remove unused full-svn-test target
Date: Tue, 23 Feb 2016 01:01:55 +0900 [thread overview]
Message-ID: <56CB30F3.40908@f2.dion.ne.jp> (raw)
In-Reply-To: <20160222030814.GA18817@dcvr.yhbt.net>
On 2016/02/22 12:08 +0900, Eric Wong wrote:
> git-svn has not supported GIT_SVN_NO_OPTIMIZE_COMMITS for
> the "set-tree" sub-command in 9 years since commit 490f49ea5899
> ("git-svn: remove optimized commit stuff for set-tree").
>
> So remove this target to avoid confusion.
> diff --git a/t/Makefile b/t/Makefile
> index 43b15e3..ad97a7e 100644
...
> -# we can test NO_OPTIMIZE_COMMITS independently of LC_ALL
> -full-svn-test:
> - $(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C
> - $(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=0 LC_ALL=en_US.UTF-8
The variable TSVN becomes unused by this removal. It should be removed
together, shouldn't it?
--
k_satoda
next prev parent reply other threads:[~2016-02-22 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 3:08 [PATCH] tests: remove unused full-svn-test target Eric Wong
2016-02-22 16:01 ` Kazutoshi Satoda [this message]
2016-02-23 6:26 ` [PATCH v2] tests: remove no-op " Eric Wong
2016-02-23 6:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CB30F3.40908@f2.dion.ne.jp \
--to=k_satoda@f2.dion.ne.jp \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox