From: "H. Peter Anvin" <hpa@zytor.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Xiaolong Ye <xiaolong.ye@intel.com>,
git@vger.kernel.org, ying.huang@intel.com, philip.li@intel.com,
julie.du@intel.com,
Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Dan Carpenter <dan.carpenter@oracle.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC/PATCH 1/1] format-patch: add an option to record base tree info
Date: Tue, 23 Feb 2016 17:40:45 -0800 [thread overview]
Message-ID: <56CD0A1D.9050207@zytor.com> (raw)
In-Reply-To: <87bn77hzbp.fsf@x220.int.ebiederm.org>
On 02/23/2016 01:49 PM, Eric W. Biederman wrote:
>
> So I could really respect a patch header line that said:
> tree abcdef0123456789...0123456789abcdef
>
> Where the numbers where the truncated tree hash before and after a patch
> was applied. That would seem to give a little bit of extra sanity
> checking in the application of git diffs as well.
>
I would rather have the untruncated base tree ID. The truncated file
IDs already provide the verification component, and it is *way* cheaper
to search for an untruncated ID.
-hpa
next prev parent reply other threads:[~2016-02-24 1:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 2:58 [RFC/PATCH 0/1] Add an option to git-format-patch to record base tree info Xiaolong Ye
2016-02-22 2:58 ` [RFC/PATCH 1/1] format-patch: add an option " Xiaolong Ye
2016-02-22 4:19 ` Junio C Hamano
2016-02-22 7:30 ` Jacob Keller
2016-02-23 1:47 ` Fengguang Wu
2016-02-23 6:54 ` Junio C Hamano
2016-02-23 9:17 ` Fengguang Wu
2016-02-23 9:23 ` H. Peter Anvin
2016-02-23 9:32 ` Fengguang Wu
2016-02-23 10:32 ` Dan Carpenter
2016-02-23 12:00 ` Fengguang Wu
2016-02-23 13:31 ` Dan Carpenter
2016-02-24 2:55 ` Fengguang Wu
2016-02-24 6:30 ` Junio C Hamano
2016-02-24 7:07 ` Fengguang Wu
2016-02-24 18:34 ` Junio C Hamano
2016-02-23 19:51 ` Junio C Hamano
2016-02-23 20:08 ` Eric W. Biederman
2016-02-23 20:35 ` Junio C Hamano
2016-02-23 20:46 ` H. Peter Anvin
2016-02-23 21:49 ` Eric W. Biederman
2016-02-24 1:40 ` H. Peter Anvin [this message]
2016-02-23 22:21 ` Stefan Beller
2016-02-24 10:31 ` Michael J Gruber
2016-02-24 6:19 ` Junio C Hamano
2016-02-24 3:36 ` Fengguang Wu
2016-02-24 3:13 ` Fengguang Wu
2016-02-23 19:56 ` Eric W. Biederman
2016-02-24 2:30 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CD0A1D.9050207@zytor.com \
--to=hpa@zytor.com \
--cc=dan.carpenter@oracle.com \
--cc=ebiederm@xmission.com \
--cc=fengguang.wu@intel.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hch@lst.de \
--cc=julie.du@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philip.li@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=xiaolong.ye@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).