From: Sidhant Sharma <tigerkid001@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org
Subject: Re: GSoC 2016 Microproject
Date: Mon, 29 Feb 2016 21:02:35 +0530 [thread overview]
Message-ID: <56D46493.4040909@gmail.com> (raw)
In-Reply-To: <vpqpovfblru.fsf@anie.imag.fr>
>> First, I'm not quite sure what to put in the help message for the
>> options (--quiet, --stateless-rpc, --advertise-refs and
>> --reject-thin-pack-for-testing).
> They are currently undocumented. We sometimes have explicitly
> undocumented options (PARSE_OPT_HIDDEN) when they are used only
> internally to avoid polluting the end-user's UI.
>
> In this case, the command is anyway not meant for end-users so I think
> it would make sense to document them, but not necessarily within the the
> microproject.
So what may I put in the message parameter? I was thinking
perhaps the option itself, without hyphens. Would that be
correct?
>
>> Second, regarding the reject-thin-pack-for-testing option, currently
>> when the option is entered, `fix_thin` is unset
>> (https://github.com/git/git/blob/master/builtin/receive-pack.c#L1736).
>> But using `OPT_BOOL(...)` for the same, the variable would instead be
>> set when the option is given. I think one solution can be to invert
>> `fix_thin` after calling `parse_options`. Am I going right so far?
>> Suggestions and corrections welcome.
> Or use OPT_SET_INT(..., 0) on a variable initialized to 1.
Okay, will do that.
>> Should I make a patch for this and submit it for discussion on the mailing list?
> On this list, it is indeed often more efficient to say "here's what I'm
> done. Any comments?" than "here's what I'm about to do".
>
I'm really sorry, I'm not very familiar with mailing list etiquettes.
I'll keep that in mind :)
Thanks and regards,
Sidhant Sharma [:tk]
next prev parent reply other threads:[~2016-02-29 15:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 13:04 GSoC 2016 Microproject Sidhant Sharma
2016-02-27 13:28 ` Matthieu Moy
2016-02-27 15:20 ` Sidhant Sharma
2016-02-27 16:12 ` Matthieu Moy
2016-02-28 10:12 ` Sidhant Sharma
2016-02-29 14:51 ` Sidhant Sharma
2016-02-29 15:04 ` Matthieu Moy
2016-02-29 15:32 ` Sidhant Sharma [this message]
2016-02-29 15:51 ` Matthieu Moy
2016-03-01 11:38 ` Sidhant Sharma
2016-03-01 12:22 ` Thomas Gummerer
-- strict thread matches above, loose matches on Subject: below --
2016-02-19 8:59 GSoC 2016: Microproject Mehul Jain
2016-02-19 13:03 ` Matthieu Moy
2016-02-19 17:39 ` Mehul Jain
2016-02-19 17:50 ` Stefan Beller
2016-02-19 18:32 ` Mehul Jain
2016-02-20 14:43 ` Mehul Jain
2016-02-21 4:55 ` Matthieu Moy
2016-02-21 16:04 ` Mehul Jain
2016-02-21 18:52 ` Matthieu Moy
2016-02-22 8:10 ` Karthik Nayak
2016-02-22 10:12 ` Mehul Jain
2016-02-22 10:20 ` Duy Nguyen
2016-02-22 10:30 ` Mehul Jain
2016-02-22 11:21 ` Duy Nguyen
2016-02-22 12:28 ` Mehul Jain
2016-02-22 10:21 ` Lars Schneider
2016-02-22 10:30 ` Lars Schneider
2016-02-21 16:02 ` Mehul Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D46493.4040909@gmail.com \
--to=tigerkid001@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).