git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Stodulka <pstodulk@redhat.com>
To: "git@vger.kernel.org" <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Forgotten declaration of function path_name() in revision.h?
Date: Wed, 16 Mar 2016 19:05:49 +0100	[thread overview]
Message-ID: <56E9A07D.3080508@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]

Hi,
according to commit 9831e92 (merge) there is maybe by mistake kept declaration
of function path_name() in revision.h, whose definition was removed
and isn't used in git anymore.

Regards,
Petr


======================================================================
From ae72c8f9085b3b7bd84f94f90ff5b0416db59d67 Mon Sep 17 00:00:00 2001
From: Petr Stodulka <pstodulk@redhat.com>
Date: Wed, 16 Mar 2016 18:51:53 +0100
Subject: [PATCH] remove obsoleted function path_name() from header file
 revision.h

The function was removed by commit 9831e92 due to possible security
issue.
---
 revision.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/revision.h b/revision.h
index dca0d38..f20168e 100644
--- a/revision.h
+++ b/revision.h
@@ -257,8 +257,6 @@ extern void put_revision_mark(const struct rev_info *revs,
 extern void mark_parents_uninteresting(struct commit *commit);
 extern void mark_tree_uninteresting(struct tree *tree);
 
-char *path_name(struct strbuf *path, const char *name);
-
 extern void show_object_with_name(FILE *, struct object *, const char *);
 
 extern void add_pending_object(struct rev_info *revs,
-- 
2.4.3


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

             reply	other threads:[~2016-03-16 18:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 18:05 Petr Stodulka [this message]
2016-03-16 18:48 ` Forgotten declaration of function path_name() in revision.h? Jeff King
2016-03-16 18:52   ` Eric Sunshine
2016-03-16 19:08   ` Petr Stodulka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E9A07D.3080508@redhat.com \
    --to=pstodulk@redhat.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).