From: Stanislav Kolotinskiy <stanislav@assembla.com>
To: Jeff King <peff@peff.net>
Cc: Dave Borowitz <dborowitz@google.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-send-pack: Fix --all option when used with directory
Date: Thu, 24 Mar 2016 15:57:59 +0200 [thread overview]
Message-ID: <56F3F267.30900@assembla.com> (raw)
In-Reply-To: <20160323212213.GA19920@sigill.intra.peff.net>
On 23/03/16 23:22, Jeff King wrote:
> Not that it matters for this bug, but for my own curiosity, what do you
> use "send-pack --all" for? I've generally assumed that nobody directly
> calls send-pack themselves these days, but of course we have no data to
> support that either way. So I am always interested to hear about unusual
> use cases.
Well, here at Assembla we're using send-pack --all for creating forks
from repos in a quick and efficient way.
> The tests are roughly grouped by functionality. send-pack tests are in
> the t540x range, and this should probably go there. Though I also
> suspect it could easily be added to the end of an existing test script,
> which is preferable.
I'm not really comfortable (yet) with git tests, so thanks for pointing
to that.
I did see t5400, but thought that bug fixes should bring their own,
separate,
test files. Also, thanks for all the explanations and for the adaptation
of my
test to a way better version!
I'm going to update the patch and will send another version. Thanks again!
--
Regards,
Stanislav
next prev parent reply other threads:[~2016-03-24 13:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 16:24 [PATCH] git-send-pack: Fix --all option when used with directory Stanislav Kolotinskiy
2016-03-23 21:22 ` Jeff King
2016-03-23 21:30 ` Jeff King
2016-03-24 13:57 ` Stanislav Kolotinskiy [this message]
2016-03-24 17:37 ` Jeff King
2016-03-24 17:49 ` Stanislav Kolotinskiy
2016-03-24 16:11 ` Junio C Hamano
2016-03-24 17:47 ` Stanislav Kolotinskiy
2016-03-24 18:02 ` Jeff King
2016-04-01 10:42 ` Stanislav Kolotinskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F3F267.30900@assembla.com \
--to=stanislav@assembla.com \
--cc=dborowitz@google.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).