From: work <motroniii@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Stefan Beller <sbeller@google.com>,
sunshine@sunshineco.com
Subject: Re: [PATCH 1/2] Modified flag field type in rev_list_info struct in bisect.h. There is no need for flag field to be signed, as it is not supposed to be used as decimal.
Date: Fri, 25 Mar 2016 15:53:36 +0300 [thread overview]
Message-ID: <56F534D0.7050104@gmail.com> (raw)
In-Reply-To: <xmqqr3ez5bcf.fsf@gitster.mtv.corp.google.com>
Yep. Thanks for your remarks. I have made a bit more research about
using old rev_list_info struct (with signed int flag) and realized, that
it doesn't appear in expressions, where using signed integer will differ
from unsigned one.
I'll take using 'unsigned' instead of 'unsigned int' in account, so if
needed, I can remake the patch in order to get it accepted.
On 03/25/2016 09:18 AM, Junio C Hamano wrote:
> Stefan Beller <sbeller@google.com> writes:
>
>> Maybe my exposure to the code was accidentally in a way such that
>> I ever only saw the version without int.
> The older part of the code tends to spell flag words with "unsigned"
> without "int", which is primarily historical fault of mine.
>
next prev parent reply other threads:[~2016-03-25 12:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 19:41 [PATCH 0/2] GSoC student Motroni Igor
2016-03-24 19:41 ` [PATCH 1/2] Modified flag field type in rev_list_info struct in bisect.h. There is no need for flag field to be signed, as it is not supposed to be used as decimal Motroni Igor
2016-03-24 19:51 ` Stefan Beller
2016-03-24 20:01 ` work
2016-03-24 22:56 ` Eric Sunshine
2016-03-24 23:04 ` Stefan Beller
2016-03-25 6:18 ` Junio C Hamano
2016-03-25 12:53 ` work [this message]
2016-03-25 16:54 ` Eric Sunshine
2016-03-24 19:41 ` [PATCH 2/2] Just a minor commit to trigger Travis Ci build Motroni Igor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F534D0.7050104@gmail.com \
--to=motroniii@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).