From: Sidhant Sharma <tigerkid001@gmail.com>
To: Miklos Vajna <vmiklos@collabora.co.uk>,
Pranit Bauva <pranit.bauva@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: Signed-off-by vs Reviewed-by
Date: Thu, 31 Mar 2016 20:27:00 +0530 [thread overview]
Message-ID: <56FD3ABC.2000500@gmail.com> (raw)
In-Reply-To: <20160331143501.GE19857@collabora.co.uk>
Hi,
On Thursday 31 March 2016 08:05 PM, Miklos Vajna wrote:
> Hi,
>
> On Thu, Mar 31, 2016 at 07:54:47PM +0530, Pranit Bauva <pranit.bauva@gmail.com> wrote:
>> Are you suggesting to use a different email address for commiting,
>> signing off and reviewing?
> Let's say project A has a workflow where patch authors and maintainers
> add a "Signed-off-by: A B <a@example.com>" line. This is well-supported
> by git, various commands have a -s option to add that line.
>
> However, if project B has a workflow where patch authors add no such
> line, and reviewers add a "Reviewed-by: A B <a@example.com>" line, then
> you have to add that line manually when you do a review.
When making the string configurable, would it be a good idea to
support more than one sign-off strings? For instance, often patches
here in Git have both a Signed-Off and a Reviewed-by line. What would
you suggest for such a case?
Regards,
Sidhant
next prev parent reply other threads:[~2016-03-31 14:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 12:35 Signed-off-by vs Reviewed-by Miklos Vajna
2016-03-31 14:24 ` Pranit Bauva
2016-03-31 14:35 ` Miklos Vajna
2016-03-31 14:57 ` Sidhant Sharma [this message]
2016-03-31 15:09 ` Christian Couder
2016-03-31 16:28 ` Junio C Hamano
2016-03-31 17:21 ` Jeff King
2016-03-31 17:23 ` Junio C Hamano
2016-04-01 14:10 ` Miklos Vajna
2016-03-31 14:32 ` Jeff King
2016-03-31 15:02 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD3ABC.2000500@gmail.com \
--to=tigerkid001@gmail.com \
--cc=git@vger.kernel.org \
--cc=pranit.bauva@gmail.com \
--cc=vmiklos@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).