From: "Dana How" <danahow@gmail.com>
To: "Alex Riesen" <raa.lkml@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <junkio@cox.net>,
danahow@gmail.com
Subject: Re: [PATCH] Use GIT_OBJECT_DIR for temporary files of pack-objects
Date: Mon, 7 May 2007 14:59:49 -0700 [thread overview]
Message-ID: <56b7f5510705071459pceb8590j47bde5cc6a3e60a0@mail.gmail.com> (raw)
In-Reply-To: <20070507213347.GB3436@steel.home>
On 5/7/07, Alex Riesen <raa.lkml@gmail.com> wrote:
> Dana How, Mon, May 07, 2007 19:51:24 +0200:
> > On 5/7/07, Alex Riesen <raa.lkml@gmail.com> wrote:
> > >I'm not sure about fsck cleaning up after crashed/killed pack-objects:
> > >not sure I _can_ detect if the temp files really are just leftovers.
> >
> > It looks like you create temp file in objects , not objects/pack .
> >
> > So a rule could be : packs left in the former are crashed/killed,
> > and packs in the latter are complete?
>
> How do you know for sure that they are _left_ already?
Ah, e.g. you're packing and fsck'ing at the same time?
Then you can't know. Never mind...
> > You should also look at $PACKTMP in git-repack.sh .
> > In it $GIT_DIR should probably be $GIT_OBJECT_DIRECTORY ?
>
> I think it should, but it is already not the working directory, so my
> original complaint does not apply
OK, if I have to further change my --max-pack-size patchset
which touches git-repack.sh, I'll roll this in.
Thanks,
--
Dana L. How danahow@gmail.com +1 650 804 5991 cell
next prev parent reply other threads:[~2007-05-07 21:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 9:25 repack: handling of .keep files Alex Riesen
2007-05-04 9:56 ` Junio C Hamano
2007-05-04 10:42 ` Alex Riesen
2007-05-04 16:59 ` Junio C Hamano
2007-05-04 17:24 ` Alex Riesen
2007-05-04 19:20 ` Junio C Hamano
[not found] ` <20070507173324.GA3436@steel.home>
2007-05-07 17:51 ` [PATCH] Use GIT_OBJECT_DIR for temporary files of pack-objects Dana How
2007-05-07 21:33 ` Alex Riesen
2007-05-07 21:59 ` Dana How [this message]
2007-05-04 19:40 ` repack: handling of .keep files Nicolas Pitre
2007-05-04 21:54 ` [PATCH] Handle return code of parse_commit in revision machinery Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56b7f5510705071459pceb8590j47bde5cc6a3e60a0@mail.gmail.com \
--to=danahow@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).