git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Dana How" <danahow@gmail.com>
To: "Sam Vilain" <sam.vilain@catalyst.net.nz>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	git@vger.kernel.org, danahow@gmail.com
Subject: Re: [PATCH] [RFC] Generational repacking
Date: Wed, 6 Jun 2007 17:04:46 -0700	[thread overview]
Message-ID: <56b7f5510706061704r34692c49v994ff368bbc12d05@mail.gmail.com> (raw)
In-Reply-To: <11811281053874-git-send-email-sam.vilain@catalyst.net.nz>

On 6/6/07, Sam Vilain <sam.vilain@catalyst.net.nz> wrote:
> This is a quick hack at generational repacking.  The idea is that you
> successively do larger repack runs as the number of packs accumulates.
>
> The commandline interface for this should be considered development
> grade only, and of course there are no tests and very verbose output
> :)
>
> The useful invocation of this is git-repack -d -g
>
> The -a option then becomes a degenerate case of generative repacking.
>
> The intention is that this should end up light enough to be triggered
> automatically whenever the (approximate) count of loose objects hits a
> threshold, like 100 or 1000 - making git repositories "maintenance
> free".

This patch complicates git-repack.sh quite a bit and
I'm unclear on what _problem_ you're addressing.
The recent LRU preferred pack patch
reduces much of the value in keeping a repository tidy
("tidy" == "few pack files").

Already git-gc calls git-repack -a -d.  How do you plan to change this?
I wonder if you should be making git-gc more intelligent instead.

Also,  you introduce a new pack properties file (.gen) which seems
awkward to me.

Perhaps something like this would be useful on a huge repository
under active use.  But delta re-use makes full repacking quite quick for
a reasonably-sized repository already,  and I don't see this being very useful
for a repository which is large due to large objects.

Thanks,
-- 
Dana L. How  danahow@gmail.com  +1 650 804 5991 cell

  parent reply	other threads:[~2007-06-07  0:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-06 11:08 [PATCH] [RFC] Generational repacking Sam Vilain
2007-06-06 22:46 ` Junio C Hamano
2007-06-06 22:53   ` Sam Vilain
2007-06-07  0:04 ` Dana How [this message]
2007-06-07  2:28   ` Sam Vilain
2007-06-07  3:20     ` Nicolas Pitre
2007-06-07  5:13       ` Sam Vilain
2007-06-07 13:38         ` Nicolas Pitre
2007-06-07 21:29           ` Sam Vilain
2007-06-07 19:46       ` Martin Langhoff
2007-06-07 21:36         ` Sam Vilain
2007-06-07 22:51           ` Martin Langhoff
2007-06-07  3:05   ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56b7f5510706061704r34692c49v994ff368bbc12d05@mail.gmail.com \
    --to=danahow@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sam.vilain@catalyst.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).