* [PATCH] comment for a long #ifdef
@ 2016-04-04 1:00 Ivan Pozdeev
2016-04-04 1:54 ` Eric Sunshine
2016-04-04 17:54 ` Junio C Hamano
0 siblings, 2 replies; 4+ messages in thread
From: Ivan Pozdeev @ 2016-04-04 1:00 UTC (permalink / raw)
To: git
---
compat/poll/poll.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/compat/poll/poll.c b/compat/poll/poll.c
index db4e03e..5eb0280 100644
--- a/compat/poll/poll.c
+++ b/compat/poll/poll.c
@@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
}
return rc;
-#else
+#else /* #ifndef WIN32_NATIVE */
static struct timeval tv0;
static HANDLE hEvent;
WSANETWORKEVENTS ev;
@@ -622,5 +622,5 @@ restart:
}
return rc;
-#endif
+#endif /* #ifndef WIN32_NATIVE */
}
--
1.9.5.msysgit.1
--
Regards,
Ivan
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] comment for a long #ifdef
2016-04-04 1:00 [PATCH] comment for a long #ifdef Ivan Pozdeev
@ 2016-04-04 1:54 ` Eric Sunshine
2016-04-04 17:23 ` Ivan Pozdeev
2016-04-04 17:54 ` Junio C Hamano
1 sibling, 1 reply; 4+ messages in thread
From: Eric Sunshine @ 2016-04-04 1:54 UTC (permalink / raw)
To: Ivan Pozdeev; +Cc: Git List
On Sun, Apr 3, 2016 at 9:00 PM, Ivan Pozdeev <vano@mail.mipt.ru> wrote:
> ---
Missing sign-off. See Documentation/SubmittingPatches.
> compat/poll/poll.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/compat/poll/poll.c b/compat/poll/poll.c
> index db4e03e..5eb0280 100644
> --- a/compat/poll/poll.c
> +++ b/compat/poll/poll.c
> @@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
> }
>
> return rc;
> -#else
> +#else /* #ifndef WIN32_NATIVE */
> static struct timeval tv0;
> static HANDLE hEvent;
> WSANETWORKEVENTS ev;
> @@ -622,5 +622,5 @@ restart:
> }
>
> return rc;
> -#endif
> +#endif /* #ifndef WIN32_NATIVE */
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] comment for a long #ifdef
2016-04-04 1:54 ` Eric Sunshine
@ 2016-04-04 17:23 ` Ivan Pozdeev
0 siblings, 0 replies; 4+ messages in thread
From: Ivan Pozdeev @ 2016-04-04 17:23 UTC (permalink / raw)
To: git
Signed-off-by: Ivan Pozdeev
---
compat/poll/poll.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/compat/poll/poll.c b/compat/poll/poll.c
index db4e03e..5eb0280 100644
--- a/compat/poll/poll.c
+++ b/compat/poll/poll.c
@@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
}
return rc;
-#else
+#else /* #ifndef WIN32_NATIVE */
static struct timeval tv0;
static HANDLE hEvent;
WSANETWORKEVENTS ev;
@@ -622,5 +622,5 @@ restart:
}
return rc;
-#endif
+#endif /* #ifndef WIN32_NATIVE */
}
--
1.9.5.msysgit.1
--
Regards,
Ivan
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] comment for a long #ifdef
2016-04-04 1:00 [PATCH] comment for a long #ifdef Ivan Pozdeev
2016-04-04 1:54 ` Eric Sunshine
@ 2016-04-04 17:54 ` Junio C Hamano
1 sibling, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2016-04-04 17:54 UTC (permalink / raw)
To: Ivan Pozdeev; +Cc: git
Ivan Pozdeev <vano@mail.mipt.ru> writes:
> ---
> compat/poll/poll.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
As Eric pointed out, please sign-off your patch.
> diff --git a/compat/poll/poll.c b/compat/poll/poll.c
> index db4e03e..5eb0280 100644
> --- a/compat/poll/poll.c
> +++ b/compat/poll/poll.c
> @@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
> }
>
> return rc;
> -#else
> +#else /* #ifndef WIN32_NATIVE */
> static struct timeval tv0;
> static HANDLE hEvent;
> WSANETWORKEVENTS ev;
> @@ -622,5 +622,5 @@ restart:
> }
>
> return rc;
> -#endif
> +#endif /* #ifndef WIN32_NATIVE */
> }
> --
> 1.9.5.msysgit.1
There also is an #ifndef/#else/#endif in abspath.c that is larger
than a typical patch context; could you include a fix for that, too?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-04 17:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-04 1:00 [PATCH] comment for a long #ifdef Ivan Pozdeev
2016-04-04 1:54 ` Eric Sunshine
2016-04-04 17:23 ` Ivan Pozdeev
2016-04-04 17:54 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).