From: "Tom G. Christensen" <tgc@jupiterrise.com>
To: git@vger.kernel.org
Subject: Hardcoded #!/bin/sh in t5532 causes problems on Solaris
Date: Sat, 9 Apr 2016 22:27:37 +0200 [thread overview]
Message-ID: <570965B9.9040207@jupiterrise.com> (raw)
Hello,
Looking at the testsuite results on Solaris I see a failure in t5532.3.
Running the testsuite with -v -i revealed a shell syntax error:
proxying for example.com 9418
./proxy: syntax error at line 3: `cmd=$' unexpected
not ok 3 - fetch through proxy works
#
# git fetch fake &&
# echo one >expect &&
# git log -1 --format=%s FETCH_HEAD >actual &&
# test_cmp expect actual
#
Looking a t5532-fetch-proxy.sh the problem is obvious, it writes out a
helper script which explicitly uses #!/bin/sh but fails to take into
account that systems like Solaris has an ancient /bin/sh that knows
nothing about POSIX things like $().
Replacing $() with `` was enough to make the test pass.
-tgc
next reply other threads:[~2016-04-09 20:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-09 20:27 Tom G. Christensen [this message]
2016-04-09 21:04 ` Hardcoded #!/bin/sh in t5532 causes problems on Solaris Jeff King
2016-04-09 22:29 ` Tom G. Christensen
2016-04-09 22:37 ` Jeff King
2016-04-10 0:37 ` Junio C Hamano
2016-04-10 19:01 ` Junio C Hamano
2016-04-10 21:51 ` Eric Sunshine
2016-04-11 16:42 ` Junio C Hamano
2016-04-11 17:27 ` Jeff King
2016-04-11 17:32 ` Jeff King
2016-04-12 16:58 ` Junio C Hamano
2016-04-12 17:12 ` Junio C Hamano
2016-04-12 17:23 ` Jeff King
2016-04-12 17:22 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570965B9.9040207@jupiterrise.com \
--to=tgc@jupiterrise.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).