From: Stefan Dotterweich <stefandotterweich@gmx.de>
To: git@vger.kernel.org
Cc: Paul Mackerras <paulus@samba.org>
Subject: [PATCH] gitk: Fix missing commits when using -S or -G
Date: Fri, 6 May 2016 13:56:21 +0200 [thread overview]
Message-ID: <572C8665.8090707@gmx.de> (raw)
When -S or -G is used as a filter option, the resulting commit list
rarely contains all matching commits. Only a certain number of commits
are displayed and the rest are missing.
"git log --boundary -S" does not return as many boundary commits as you
might expect. gitk makes up for this in closevargs() by adding missing
parent (boundary) commits. However, it does not change $numcommits,
which limits how many commits are shown. In the end, some commits at the
end of the commit list are simply not shown.
Change $numcommits whenever a missing parent is added.
Signed-off-by: Stefan Dotterweich <stefandotterweich@gmx.de>
---
gitk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gitk b/gitk
index 805a1c7..b0da174 100755
--- a/gitk
+++ b/gitk
@@ -1315,7 +1315,7 @@ proc commitonrow {row} {
proc closevarcs {v} {
global varctok varccommits varcid parents children
- global cmitlisted commitidx vtokmod
+ global cmitlisted commitidx vtokmod numcommits
set missing_parents 0
set scripts {}
@@ -1339,7 +1339,7 @@ proc closevarcs {v} {
modify_arc $v $b
}
lappend varccommits($v,$b) $p
- incr commitidx($v)
+ set numcommits [incr commitidx($v)]
set scripts [check_interest $p $scripts]
}
}
--
2.7.4
next reply other threads:[~2016-05-06 11:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 11:56 Stefan Dotterweich [this message]
2016-05-06 12:16 ` [PATCH v2] gitk: Fix missing commits when using -S or -G Stefan Dotterweich
2016-05-09 3:45 ` Paul Mackerras
2016-05-09 5:33 ` Stefan Dotterweich
2016-06-04 8:47 ` [PATCH v3] " Stefan Dotterweich
2016-12-12 0:39 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572C8665.8090707@gmx.de \
--to=stefandotterweich@gmx.de \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).