From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] rerere: plug memory leaks upon "rerere forget" failure
Date: Thu, 19 May 2016 21:43:20 +0200 [thread overview]
Message-ID: <573E1758.8090801@kdbg.org> (raw)
In-Reply-To: <xmqqpossi31p.fsf@gitster.mtv.corp.google.com>
Am 12.05.2016 um 01:32 schrieb Junio C Hamano:
> + if (unlink(filename)) {
> + if (errno == ENOENT)
> + error("no remembered resolution for %s", path);
> + else
> + error("cannot unlink %s: %s", filename, strerror(errno));
> + goto fail_exit;
> + };
If you haven't merged this topic yet, you might want to remove this
superfluous empty statement.
-- Hannes
next prev parent reply other threads:[~2016-05-19 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 23:32 [PATCH] rerere: plug memory leaks upon "rerere forget" failure Junio C Hamano
2016-05-19 19:43 ` Johannes Sixt [this message]
2016-05-19 20:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573E1758.8090801@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox